| Summary: | SourceCode should be copied when generating bytecode for functions | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||||||
| Component: | JavaScriptCore | Assignee: | Tadeu Zagallo <tzagallo> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tadeu Zagallo
2019-02-12 05:32:30 PST
Created attachment 361793 [details]
Patch
Please add a fix me pointing to: https://bugs.webkit.org/show_bug.cgi?id=194576 *** Bug 194575 has been marked as a duplicate of this bug. *** It would be nice if some of our bytecode cache tests used the code path of creating all functions up front to get better test coverage Created attachment 361908 [details]
Patch for landing
Comment on attachment 361908 [details] Patch for landing Rejecting attachment 361908 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 361908, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11133542 (In reply to Saam Barati from comment #4) > It would be nice if some of our bytecode cache tests used the code path of > creating all functions up front to get better test coverage Yes, I agree. I tried replacing the current bytecode-cache tests with that when I added the API, but it failed on tests that loaded other files dynamically. We should think of other way of doing that. Created attachment 361909 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 361909 [details]: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. Comment on attachment 361909 [details] Patch for landing Clearing flags on attachment: 361909 Committed r241431: <https://trac.webkit.org/changeset/241431> All reviewed patches have been landed. Closing bug. |