Bug 193697

Summary: [ews-app] Rename ews model steps to step
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, kocsen_chung, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193695
https://bugs.webkit.org/show_bug.cgi?id=193729
Attachments:
Description Flags
Proposed patch
none
Proposed patch lforschler: review+

Aakash Jain
Reported 2019-01-22 16:08:32 PST
The recommended naming convention for models in Django is to use singular noun. Therefore, we should rename 'steps' to 'step' in ews-app model.
Attachments
Proposed patch (2.01 KB, patch)
2019-01-22 17:04 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Proposed patch (2.48 KB, patch)
2019-01-23 11:18 PST, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-01-22 17:04:44 PST
Created attachment 359813 [details] Proposed patch
Aakash Jain
Comment 2 2019-01-23 11:18:38 PST
Created attachment 359909 [details] Proposed patch
Kocsen Chung
Comment 3 2019-01-23 11:21:24 PST
Comment on attachment 359909 [details] Proposed patch r+; looks good to me.
Aakash Jain
Comment 4 2019-01-23 13:54:49 PST
Committed r240359: <https://trac.webkit.org/changeset/240359>
Radar WebKit Bug Importer
Comment 5 2019-01-23 13:55:33 PST
<rdar://problem/47492748>
Note You need to log in before you can comment on or make changes to this bug.