Bug 193568 – Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Switch remaining UIKit soft-linking in WebCore over to UIKitSoftLink.{cpp,h}.

This gets rid of 16 instances of duplicate soft-linking code for UIKit.framework.

[Radar WebKit Bug Importer]

<rdar://problem/47381130>

[David Kilzer (:ddkilzer)]

Created attachment 359472 [details]
Patch v1

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #0)
> Switch remaining UIKit soft-linking in WebCore over to UIKitSoftLink.{cpp,h}.
> 
> This gets rid of 16 instances of duplicate soft-linking code for
> UIKit.framework.

Now 17 instances because I fixed WebView.mm in WebKitLegacy, too!

[David Kilzer (:ddkilzer)]

Created attachment 359491 [details]
Patch v2

[WebKit Commit Bot]

Comment on attachment 359491 [details]
Patch v2

Clearing flags on attachment: 359491

Committed r240168: <https://trac.webkit.org/changeset/240168>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[David Kilzer (:ddkilzer)]

(In reply to WebKit Commit Bot from comment #5)
> Comment on attachment 359491 [details]
> Patch v2
> 
> Clearing flags on attachment: 359491
> 
> Committed r240168: <https://trac.webkit.org/changeset/240168>

Follow-up build fix:

Committed r240169: <https://trac.webkit.org/changeset/240169>

[David Kilzer (:ddkilzer)]

(In reply to David Kilzer (:ddkilzer) from comment #7)
> (In reply to WebKit Commit Bot from comment #5)
> > Comment on attachment 359491 [details]
> > Patch v2
> > 
> > Clearing flags on attachment: 359491
> > 
> > Committed r240168: <https://trac.webkit.org/changeset/240168>
> 
> Follow-up build fix:
> 
> Committed r240169: <https://trac.webkit.org/changeset/240169>

A second follow-up build fix:

Committed r240183: <https://trac.webkit.org/changeset/240183>