Summary: | Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fred.wang, simon.fraser, webkit-bug-importer, zalan | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2018-12-22 11:37:00 PST
Created attachment 358024 [details]
Patch
Might conflict with the patch in bug 193009. Comment on attachment 358024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358024&action=review > Source/WebCore/rendering/RenderLayerCompositor.h:474 > + // FIXME: make the coordinated/async terminology consistent. Can you please elaborate about this FIXME? Do you think we use "Coordinated" or "Async" scrolling everywhere? (In reply to Frédéric Wang (:fredw) from comment #5) > Comment on attachment 358024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=358024&action=review > > > Source/WebCore/rendering/RenderLayerCompositor.h:474 > > + // FIXME: make the coordinated/async terminology consistent. > > Can you please elaborate about this FIXME? Do you think we use "Coordinated" > or "Async" scrolling everywhere? I think we should pick one and stick with it, yes. (In reply to Simon Fraser (smfr) from comment #6) > (In reply to Frédéric Wang (:fredw) from comment #5) > > Comment on attachment 358024 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=358024&action=review > > > > > Source/WebCore/rendering/RenderLayerCompositor.h:474 > > > + // FIXME: make the coordinated/async terminology consistent. > > > > Can you please elaborate about this FIXME? Do you think we use "Coordinated" > > or "Async" scrolling everywhere? > > I think we should pick one and stick with it, yes. For the record, I've opened https://bugs.webkit.org/show_bug.cgi?id=193394 but I'm not exactly how much we want to do. |