Bug 193010

Summary: Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: fred.wang, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+

Description Simon Fraser (smfr) 2018-12-22 11:37:00 PST
Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
Comment 1 Simon Fraser (smfr) 2018-12-22 11:38:18 PST
Created attachment 358024 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-12-22 11:38:45 PST
Might conflict with the patch in bug 193009.
Comment 3 Simon Fraser (smfr) 2019-01-02 13:22:33 PST
https://trac.webkit.org/r239576
Comment 4 Radar WebKit Bug Importer 2019-01-02 13:23:36 PST
<rdar://problem/47009446>
Comment 5 Frédéric Wang (:fredw) 2019-01-04 06:11:47 PST
Comment on attachment 358024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358024&action=review

> Source/WebCore/rendering/RenderLayerCompositor.h:474
> +    // FIXME: make the coordinated/async terminology consistent.

Can you please elaborate about this FIXME? Do you think we use "Coordinated" or "Async" scrolling everywhere?
Comment 6 Simon Fraser (smfr) 2019-01-04 10:10:02 PST
(In reply to Frédéric Wang (:fredw) from comment #5)
> Comment on attachment 358024 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=358024&action=review
> 
> > Source/WebCore/rendering/RenderLayerCompositor.h:474
> > +    // FIXME: make the coordinated/async terminology consistent.
> 
> Can you please elaborate about this FIXME? Do you think we use "Coordinated"
> or "Async" scrolling everywhere?

I think we should pick one and stick with it, yes.
Comment 7 Frédéric Wang (:fredw) 2019-01-16 02:22:59 PST
(In reply to Simon Fraser (smfr) from comment #6)
> (In reply to Frédéric Wang (:fredw) from comment #5)
> > Comment on attachment 358024 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=358024&action=review
> > 
> > > Source/WebCore/rendering/RenderLayerCompositor.h:474
> > > +    // FIXME: make the coordinated/async terminology consistent.
> > 
> > Can you please elaborate about this FIXME? Do you think we use "Coordinated"
> > or "Async" scrolling everywhere?
> 
> I think we should pick one and stick with it, yes.

For the record, I've opened https://bugs.webkit.org/show_bug.cgi?id=193394 but I'm not exactly how much we want to do.