Bug 189936
| Summary: | [WHLSL] Metal codegen needs to correctly handle all entry point arguments | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Thomas Denney <tdenney> |
| Component: | WebGPU | Assignee: | Thomas Denney <tdenney> |
| Status: | RESOLVED MOVED | ||
| Severity: | Normal | CC: | dino, mmaxfield |
| Priority: | P2 | ||
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=189955 | ||
| Bug Depends on: | |||
| Bug Blocks: | 176199 | ||
Thomas Denney
WHLSL and MSL shader parameter/return types may differ in their layout — the stage_in parameters need to be flattened into a single struct for example — so shader entry points should unpack their parameters into the expected layout and when they exit they should repack into this format.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Myles C. Maxfield
It might be easier to implement the packing/unpacking if we make a new function that represents the entry point that just does the packing/unpacking, the global struct, and the trap statement bool
Myles C. Maxfield
Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/26
Myles C. Maxfield
https://github.com/gpuweb/WHLSL/issues/26