Bug 189099

Summary: [WHLSL] Implement tests to verify array indexing order matches our desires
Product: WebKit Reporter: Thomas Denney <tdenney>
Component: WebGPUAssignee: Thomas Denney <tdenney>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 189101    
Bug Blocks: 176199, 189175    
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch none

Thomas Denney
Reported 2018-08-29 14:57:10 PDT
If you have a float2x4 (for example) then the first subscript index should match the first dimension and the second subscript index should match the second dimension. Likewise, if you have an array declared as float[5][4] x, then you should be able to access element x[4][3] (but not x[3][4]).
Attachments
WIP (3.24 KB, patch)
2018-08-30 14:07 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Patch (4.45 KB, patch)
2018-08-30 14:23 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Patch (4.38 KB, patch)
2018-08-30 14:27 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Patch (4.38 KB, patch)
2018-08-30 14:36 PDT, Thomas Denney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Thomas Denney
Comment 1 2018-08-30 14:07:10 PDT
Created attachment 348543 [details] WIP
Thomas Denney
Comment 2 2018-08-30 14:23:37 PDT
Created attachment 348549 [details] Patch
Thomas Denney
Comment 3 2018-08-30 14:27:40 PDT
Created attachment 348550 [details] Patch
Myles C. Maxfield
Comment 4 2018-08-30 14:32:37 PDT
Comment on attachment 348550 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348550&action=review > Tools/WebGPUShadingLanguageRI/Test.js:5591 > +let testExclusionFilter = /^disabled_/; I prefer DISABLED_
Thomas Denney
Comment 5 2018-08-30 14:36:07 PDT
Created attachment 348555 [details] Patch
WebKit Commit Bot
Comment 6 2018-08-30 14:53:51 PDT
Comment on attachment 348555 [details] Patch Clearing flags on attachment: 348555 Committed r235525: <https://trac.webkit.org/changeset/235525>
WebKit Commit Bot
Comment 7 2018-08-30 14:53:52 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-08-31 08:56:46 PDT
<rdar://problem/43941946>
Myles C. Maxfield
Comment 9 2018-10-13 15:05:11 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/72
Note You need to log in before you can comment on or make changes to this bug.