Currently WHLSL parses the declaration "int[2][3] array” as an array of length 3 of arrays of 2 integers; we need the reverse to match C.
Created attachment 348568 [details] Patch
Comment on attachment 348568 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348568&action=review > Tools/ChangeLog:7 > + > + Reviewed by NOBODY (OOPS!). > + Need some description > Tools/WebGPUShadingLanguageRI/Parse.js:266 > + // token is updated each iteration, so constructors must use the token associated with their iteration. > + const tokenCopy = token; can you fix this by saying "while (let token = ...)"?
Created attachment 348570 [details] Patch
Created attachment 348571 [details] Patch
Comment on attachment 348571 [details] Patch Clearing flags on attachment: 348571 Committed r235533: <https://trac.webkit.org/changeset/235533>
All reviewed patches have been landed. Closing bug.
<rdar://problem/43941968>
Migrated to https://github.com/gpuweb/WHLSL/issues/50