Bug 189101 - [WHLSL] Test row-majorness of matrices
Summary: [WHLSL] Test row-majorness of matrices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 176199 189099
  Show dependency tree / graph
 
Reported: 2018-08-29 15:32 PDT by Myles C. Maxfield
Modified: 2018-10-13 15:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.17 KB, patch)
2018-08-29 15:32 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (7.67 KB, patch)
2018-08-29 16:52 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (7.21 KB, patch)
2018-08-29 16:58 PDT, Myles C. Maxfield 		ews-feeder: review-
mmaxfield: commit-queue+
Details | Formatted Diff | Diff
Patch for committing (7.21 KB, patch)
2018-08-29 18:10 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (7.22 KB, patch)
2018-08-29 18:10 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-08-29 15:32:29 PDT 
[WHLSL] Test row-majorness of matrices
Comment 1 Myles C. Maxfield 2018-08-29 15:32:55 PDT 
Created attachment 348440 [details]
Patch
Comment 2 Thomas Denney 2018-08-29 16:12:26 PDT 
Comment on attachment 348440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348440&action=review

> Tools/WebGPUShadingLanguageRI/Test.js:5540
> +    let result = callFunction(program, "foo", []);

It would be better to have separate functions that we call to check each element, e.g.

float foo00() { return foo()[0][0]; }

checkFloat(program, callFunction(program, “foo00”, []), 17 * 2 + 31 * 3 + 47 * 5)

as this will make it easier to tie into the Metal test suite.
Comment 3 Myles C. Maxfield 2018-08-29 16:52:21 PDT 
Created attachment 348451 [details]
Patch
Comment 4 Thomas Denney 2018-08-29 16:56:01 PDT 
Comment on attachment 348451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348451&action=review

> Tools/WebGPUShadingLanguageRI/Test.html:155
> +    var tester = doTest(/matrixMultiplication/);

This shouldn’t be here.
Comment 5 Myles C. Maxfield 2018-08-29 16:58:38 PDT 
Created attachment 348452 [details]
Patch
Comment 6 Dean Jackson 2018-08-29 18:02:03 PDT 
Comment on attachment 348452 [details]
Patch

r=me too
Comment 7 EWS 2018-08-29 18:02:46 PDT 
Comment on attachment 348452 [details]
Patch

Rejecting attachment 348452 [details] from review queue.

tdenney@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 8 Myles C. Maxfield 2018-08-29 18:10:20 PDT 
Created attachment 348457 [details]
Patch for committing
Comment 9 Myles C. Maxfield 2018-08-29 18:10:45 PDT 
Created attachment 348458 [details]
Patch for committing
Comment 10 WebKit Commit Bot 2018-08-29 18:50:29 PDT 
Comment on attachment 348458 [details]
Patch for committing

Clearing flags on attachment: 348458

Committed r235493: <https://trac.webkit.org/changeset/235493>
Comment 11 WebKit Commit Bot 2018-08-29 18:50:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2018-08-29 18:51:45 PDT 
<rdar://problem/43868352>
Comment 13 Myles C. Maxfield 2018-10-13 15:04:06 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/71