Bug 189101 – [WHLSL] Test row-majorness of matrices

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[WHLSL] Test row-majorness of matrices

[Myles C. Maxfield]

Created attachment 348440 [details]
Patch

[Thomas Denney]

Comment on attachment 348440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348440&action=review

> Tools/WebGPUShadingLanguageRI/Test.js:5540
> +    let result = callFunction(program, "foo", []);

It would be better to have separate functions that we call to check each element, e.g.

float foo00() { return foo()[0][0]; }

checkFloat(program, callFunction(program, “foo00”, []), 17 * 2 + 31 * 3 + 47 * 5)

as this will make it easier to tie into the Metal test suite.

[Myles C. Maxfield]

Created attachment 348451 [details]
Patch

[Thomas Denney]

Comment on attachment 348451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348451&action=review

> Tools/WebGPUShadingLanguageRI/Test.html:155
> +    var tester = doTest(/matrixMultiplication/);

This shouldn’t be here.

[Myles C. Maxfield]

Created attachment 348452 [details]
Patch

[Dean Jackson]

Comment on attachment 348452 [details]
Patch

r=me too

[EWS]

Comment on attachment 348452 [details]
Patch

Rejecting attachment 348452 [details] from review queue.

[e-mail] does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Myles C. Maxfield]

Created attachment 348457 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 348458 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 348458 [details]
Patch for committing

Clearing flags on attachment: 348458

Committed r235493: <https://trac.webkit.org/changeset/235493>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/43868352>

[Myles C. Maxfield]

Migrated to https://github.com/gpuweb/WHLSL/issues/71