Bug 188779

Summary: Support "name" option for dedicated workers
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, d, esprehn+autocc, ews-watchlist, joepeck, kondapallykalyan, rniwa, ryanhaddad, sam, tsavell, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=164678
Bug Depends on:    
Bug Blocks: 164678    
Attachments:
Description Flags
Patch
none
Patch
none
Patch joepeck: review+

Yusuke Suzuki
Reported 2018-08-20 23:02:30 PDT
Support "name" option for dedicated workers
Attachments
Patch (39.66 KB, patch)
2018-08-20 23:09 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (39.69 KB, patch)
2018-08-20 23:12 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (42.20 KB, patch)
2018-08-21 00:25 PDT, Yusuke Suzuki 		joepeck: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-08-20 23:09:34 PDT
Created attachment 347613 [details] Patch
EWS Watchlist
Comment 2 2018-08-20 23:12:11 PDT
Attachment 347613 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2018-08-20 23:12:31 PDT
Created attachment 347614 [details] Patch
EWS Watchlist
Comment 4 2018-08-20 23:15:12 PDT
Attachment 347614 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 5 2018-08-21 00:25:39 PDT
Created attachment 347618 [details] Patch
Yusuke Suzuki
Comment 6 2018-08-21 00:27:59 PDT
*** Bug 172016 has been marked as a duplicate of this bug. ***
EWS Watchlist
Comment 7 2018-08-21 00:28:08 PDT
Attachment 347618 [details] did not pass style-queue: ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:75: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 8 2018-08-21 11:22:33 PDT
Comment on attachment 347618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347618&action=review r=me! > Source/WebCore/ChangeLog:14 > + [2]: https://bugs.webkit.org/show_bug.cgi?id=164678 Yep! I have been looking forward to this for a while, thanks!
Joseph Pecoraro
Comment 9 2018-08-21 11:23:46 PDT
Would it be worth a test of our own for Worker names, or should we just rely on the WPTs?
Yusuke Suzuki
Comment 10 2018-08-21 11:27:04 PDT
(In reply to Joseph Pecoraro from comment #9) > Would it be worth a test of our own for Worker names, or should we just rely > on the WPTs? We can add tests additionally! I'll add several ones :)
Yusuke Suzuki
Comment 11 2018-08-21 11:40:08 PDT
Committed r235128: <https://trac.webkit.org/changeset/235128>
Radar WebKit Bug Importer
Comment 12 2018-08-21 11:42:29 PDT
<rdar://problem/43570680>
Truitt Savell
Comment 13 2018-08-21 14:05:37 PDT
The new test: http/wpt/workers/name-property-enhanced.html From patch: <https://trac.webkit.org/changeset/235128> Is flakey and failed on most builds: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fworkers%2Fname-property-enhanced.html
Joseph Pecoraro
Comment 14 2018-08-21 14:29:51 PDT
> Is flakey and failed on most builds: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=http%2Fwpt%2Fworkers%2Fname-property-enhanced. > html Thanks for the heads up. Do you file bugzilla bugs on these failures? What is the failure diff? It requires a lot of clicks from the slow loading flakiness dashboard to act!
Joseph Pecoraro
Comment 15 2018-08-21 14:31:54 PDT
Looks like the failure is out of order results: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r235128%20(12237)/results.html > --- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/http/wpt/workers/name-property-enhanced-expected.txt > +++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/http/wpt/workers/name-property-enhanced-actual.txt > @@ -2,7 +2,7 @@ > Harness Error (FAIL), message = 2 duplicate test names: "name property value for DedicatedWorkerGlobalScope", "name property is replaceable for DedicatedWorkerGlobalScope" > > PASS name property value for DedicatedWorkerGlobalScope > -PASS name property is replaceable for DedicatedWorkerGlobalScope > PASS name property value for DedicatedWorkerGlobalScope > PASS name property is replaceable for DedicatedWorkerGlobalScope > +PASS name property is replaceable for DedicatedWorkerGlobalScope
Joseph Pecoraro
Comment 16 2018-08-21 14:33:19 PDT
Maybe in WPT fetch_tests_from_worker(...) might run tests in parallel instead of serial?
Ryan Haddad
Comment 17 2018-08-21 19:04:07 PDT
This test is failing more often than it is passing on the bots and is slowing down EWS. We should roll this out if it needs more investigation.
Ryan Haddad
Comment 18 2018-08-21 19:22:54 PDT
Reverted r235128 for reason: The test added with this change is frequently failing. Committed r235155: <https://trac.webkit.org/changeset/235155>
Yusuke Suzuki
Comment 19 2018-08-21 21:58:32 PDT
Committed r235159: <https://trac.webkit.org/changeset/235159>
Yusuke Suzuki
Comment 20 2018-08-21 21:59:14 PDT
Thanks, I've relanded the patch by splitting the test into 2 files to make it deterministic!
Note You need to log in before you can comment on or make changes to this bug.