Bug 186401

Summary: [Mojave] Enable build
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ddkilzer, lforschler, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186403
https://bugs.webkit.org/show_bug.cgi?id=186404
https://bugs.webkit.org/show_bug.cgi?id=184554
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Jonathan Bedard
Reported 2018-06-07 10:48:39 PDT
A few build fixes for the Mojave seed build.
Attachments
Patch (2.91 KB, patch)
2018-06-07 11:49 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.93 KB, patch)
2018-06-07 14:49 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2018-06-08 10:32 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.75 KB, patch)
2018-06-08 11:25 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.70 KB, patch)
2018-06-08 13:06 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2018-06-07 10:48:53 PDT
<rdar://problem/39759031>
Jonathan Bedard
Comment 2 2018-06-07 11:49:56 PDT
Created attachment 342197 [details] Patch
Alexey Proskuryakov
Comment 3 2018-06-07 13:08:34 PDT
PAL/pal/spi/cocoa/QuartzCoreSPI.h:76:35: error: '__MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef] #if !ENABLE(MINIMAL_SIMULATOR) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
Jonathan Bedard
Comment 4 2018-06-07 14:49:57 PDT
Created attachment 342207 [details] Patch
mitz
Comment 5 2018-06-07 15:15:21 PDT
Comment on attachment 342207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342207&action=review > Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:116 > +SOFT_LINK(DataDetectors, DDResultGetCFTypeID, CFTypeID, (void), ()) This one is kind of surprising. How are we able to successfully call this function when building with an Apple-internal Mojave SDK if we don’t soft-link it?
Jonathan Bedard
Comment 6 2018-06-08 10:32:30 PDT
Created attachment 342286 [details] Patch
mitz
Comment 7 2018-06-08 10:34:59 PDT
Comment on attachment 342286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342286&action=review > Source/WebCore/PAL/pal/spi/mac/DataDetectorsSPI.h:93 > +CFTypeID DDResultGetCFTypeID(void); Pretty sure our convention for functions in SPI.h headers is to declare them in a section of the file that’s not guarded with !USE(APPLE_INTERNAL_SDK). This means that when using the internal SDK, we are redeclaring them, which has the advantage of letting us know if our declaration differs from the one in the SDK.
Jonathan Bedard
Comment 8 2018-06-08 11:25:34 PDT
Created attachment 342297 [details] Patch
mitz
Comment 9 2018-06-08 11:52:36 PDT
Comment on attachment 342297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342297&action=review > Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:76 > +#if PLATFORM(MAC) && !ENABLE(MINIMAL_SIMULATOR) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 Pretty sure ENABLE(MINIMAL_SIMULATOR) is never true for PLATFORM(MAC).
Jonathan Bedard
Comment 10 2018-06-08 12:57:52 PDT
Comment on attachment 342297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=342297&action=review >> Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:76 >> +#if PLATFORM(MAC) && !ENABLE(MINIMAL_SIMULATOR) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 > > Pretty sure ENABLE(MINIMAL_SIMULATOR) is never true for PLATFORM(MAC). That does seem to be the case. Removing ENABLE(MINIMAL_SIMULATOR)
Jonathan Bedard
Comment 11 2018-06-08 13:06:48 PDT
Created attachment 342310 [details] Patch
WebKit Commit Bot
Comment 12 2018-06-08 15:11:38 PDT
Comment on attachment 342310 [details] Patch Clearing flags on attachment: 342310 Committed r232642: <https://trac.webkit.org/changeset/232642>
WebKit Commit Bot
Comment 13 2018-06-08 15:11:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2018-06-08 15:13:02 PDT
<rdar://problem/40952654>
Jonathan Bedard
Comment 15 2018-06-15 18:38:18 PDT
Note that as mentioned in <https://bugs.webkit.org/show_bug.cgi?id=18657>, the build will be broken on Seed 1. This is fixed in seed 2.
Note You need to log in before you can comment on or make changes to this bug.