Bug 182763 – REGRESSION(r228417): Broke four GTK accessibility tests

• Component: Accessibility
• Status: NEW

[Michael Catanzaro]

r228417 "AX: defer focusedUIElement notifications" broke three accessibility tests for GTK:

accessibility/gtk/aria-activedescendant-changed-notification.html
accessibility/gtk/text-in-span-block-in-a-block.html
accessibility/notification-listeners.html

These tests are not flaky, so I will add plain failure expectations for all three of them.

The failure in aria-activedescendant-change-notification looks suspiciously similar to bug #182761, but the results from the bot do not lie, that test was fine after r228279 and did not break until r228417. Looks like this first test might just need its expected results updated(?), but the other two failing tests are clearly broken now.


--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/gtk/aria-activedescendant-changed-notification-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/gtk/aria-activedescendant-changed-notification-actual.txt
@@ -6,9 +6,6 @@
 AXFocusedUIElementChanged: AXRole: AXEmbedded
 AXFocusedUIElementChanged: AXRole: AXTextField
 AXFocusedUIElementChanged: AXRole: AXGroup
-AXFocusedUIElementChanged: AXRole: AXGroup
-AXFocusedUIElementChanged: AXRole: AXGroup
-AXFocusedUIElementChanged: AXRole: AXCheckBox
 PASS successfullyParsed is true
 

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/gtk/text-in-span-block-in-a-block-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/gtk/text-in-span-block-in-a-block-actual.txt
@@ -18,25 +18,25 @@
 
 PASS accText is "AXValue:one"
 PASS setCaretOffset(elem, 1) is true
-PASS caretMovedData is "Link|1"
+FAIL caretMovedData should be Link|1. Was .
 PASS accText is "AXValue:two"
 PASS setCaretOffset(elem, 1) is true
-PASS caretMovedData is "Link|1"
+FAIL caretMovedData should be Link|1. Was .
 PASS accText is "AXValue:three"
 PASS setCaretOffset(elem, 1) is true
-PASS caretMovedData is "Link|1"
+FAIL caretMovedData should be Link|1. Was .
 PASS accText is "AXValue:before,four,after"
 PASS setCaretOffset(elem, 1) is true
-PASS caretMovedData is "Link|1"
+FAIL caretMovedData should be Link|1. Was .
 PASS accText is "AXValue:five,after"
 PASS setCaretOffset(elem, 1) is true
-PASS caretMovedData is "Link|1"
+FAIL caretMovedData should be Link|1. Was .
 PASS accText is "AXValue:before,six"
 PASS setCaretOffset(elem, 1) is true
-PASS caretMovedData is "Link|1"
+FAIL caretMovedData should be Link|1. Was .
 PASS accText is "AXValue:nospanhere"
 PASS setCaretOffset(elem, 1) is true
-PASS caretMovedData is "Link|1"
+FAIL caretMovedData should be Link|1. Was .
 PASS successfullyParsed is true
 
 TEST COMPLETE


--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/notification-listeners-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/notification-listeners-actual.txt
@@ -5,13 +5,17 @@
 
 
 Slider
+SELECT AXFocusedUIElementChanged
+GLOBAL AXFocusedUIElementChanged on element with role AXRole: AXComboBox
+SLIDER AXFocusedUIElementChanged
+GLOBAL AXFocusedUIElementChanged on element with role AXRole: AXSlider
 SELECT AXInvalidStatusChanged
 GLOBAL AXInvalidStatusChanged on element with role AXRole: AXComboBox
 SLIDER AXValueChanged
 GLOBAL AXValueChanged on element with role AXRole: AXSlider
-PASS selectNotificationCount is 1
-PASS sliderNotificationCount is 1
-PASS globalNotificationCount is 2
+FAIL selectNotificationCount should be 1. Was 2.
+FAIL sliderNotificationCount should be 1. Was 2.
+FAIL globalNotificationCount should be 2. Was 4.
 PASS successfullyParsed is true
 
 TEST COMPLETE
 TEST COMPLETE

[Radar WebKit Bug Importer]

<rdar://problem/37524003>

[Michael Catanzaro]

Ooops, I almost missed accessibility/gtk/caret-offsets.html, which is timing out:

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/gtk/caret-offsets-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/accessibility/gtk/caret-offsets-actual.txt
@@ -1,48 +1,2 @@
-A text header
+FAIL: Timed out waiting for notifyDone to be called
 
-A paragraph with a link in the middle
-
-A list item
-Block span in a list item
-Inline span in a list item
-Block span in a link in a list item
-Inline span in a link in a list item
-  
-a table cell		
-Block span in a link in a table cell
-Inline span in a link in a table cell	
-Block span in a table cell
-Inline span in a table cell
-This test is replicated from old file testatk.c and tests various scenarios of caret movement: setting caret offset and receiving text-caret-moved signal.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS root.childrenCount is 5
-PASS setCaretOffset(h1, 5) is true
-PASS caretMovedData is "Heading|5"
-PASS caretMovedData is "Paragraph|5"
-PASS caretMovedData is "Paragraph|20"
-PASS caretMovedData became "Paragraph|30"
-PASS setCaretOffset(link, 5) is true
-PASS caretMovedData is "Paragraph|17"
-PASS list.role is "AXRole: AXList"
-PASS list.childrenCount is 3
-PASS setCaretOffset(listItem, 1) is false
-PASS setCaretOffset(listItem, 5) is true
-PASS caretMovedData is "ListItem|5"
-PASS comboBox.role is "AXRole: AXComboBox"
-PASS menuPopup.role is "AXRole: AXMenu"
-PASS comboBoxOption.role is "AXRole: AXMenuItem"
-PASS setCaretOffset(comboBoxOption, 1) is false
-PASS textEntry.role is "AXRole: AXTextField"
-PASS caretMovedData is "TextField|5"
-PASS table.role is "AXRole: AXTable"
-PASS table.childrenCount is 1
-PASS row.role is "AXRole: AXRow"
-PASS tableCell.role is "AXRole: AXCell"
-PASS caretMovedData became "Cell|2"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

[chris fleizach]

These likely need to be rewritten slightly to account for focus chnages being coalesced and delayed. Often this just means putting a call inside a setTimeout

Joanie’s expertise will probably be needed but hopefully this won’t be too hard