Bug 182573

Summary: Improve NetworkResourceLoader logging to capture redirect cases
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Brent Fulgham
Reported 2018-02-07 09:26:43 PST
The logging updates in Bug 182455 did not catch redirects, which should be logged, too.
Attachments
Patch (3.20 KB, patch)
2018-02-07 09:55 PST, Brent Fulgham 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-07 09:50:33 PST
<rdar://problem/37316714>
Brent Fulgham
Comment 2 2018-02-07 09:55:41 PST
Created attachment 333299 [details] Patch
Chris Dumez
Comment 3 2018-02-07 13:46:10 PST
Comment on attachment 333299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333299&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:34 > +#import "NetworkResourceLoader.h" I am unclear why this import is needed.
Brent Fulgham
Comment 4 2018-02-07 13:53:06 PST
Comment on attachment 333299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333299&action=review >> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:34 >> +#import "NetworkResourceLoader.h" > > I am unclear why this import is needed. Oh! You are right. I added that by mistake. I'll remove it.
John Wilander
Comment 5 2018-02-07 13:58:32 PST
Just a heads up: You might have to merge since I recently landed https://bugs.webkit.org/show_bug.cgi?id=182559 that touches this code.
Brent Fulgham
Comment 6 2018-02-07 14:53:37 PST
Committed r228244: <https://trac.webkit.org/changeset/228244>
Note You need to log in before you can comment on or make changes to this bug.