Bug 177093

Summary: WSL should flag stores to constant references
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebGPUAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: jonlee, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=189210
Bug Depends on: 177303    
Bug Blocks: 176199, 189202    

Description Filip Pizlo 2017-09-18 12:00:19 PDT
Patch forthcoming.
Comment 1 Radar WebKit Bug Importer 2018-09-12 18:52:17 PDT
<rdar://problem/44403033>
Comment 2 Myles C. Maxfield 2018-09-22 04:16:06 PDT
This requires that address spaces get propagated to individual values.

constant float[] a : register(b0)
a[3] = 7;

We need to realize that the type of a[3] is "constant float"

This analysis is required for things like

device atomic_uint[] x : register(u0);
InterlockedAdd(&x[0], 1, null);

Here, we have to realize that the type of &x[0] is type "device uint*"
Comment 3 Myles C. Maxfield 2018-09-22 16:52:12 PDT

*** This bug has been marked as a duplicate of bug 189210 ***
Comment 4 Myles C. Maxfield 2018-10-13 19:46:00 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/190