Bug 176591

Summary: Make RenderLayerCompositor always use isRootLayer()
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: FramesAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176261, 176684    
Attachments:
Description Flags
Patch
none
Patch darin: review+

Frédéric Wang (:fredw)
Reported 2017-09-08 06:13:11 PDT
Sometimes, RenderLayerCompositor performs the verification &layer == m_renderView.layer() which could be replaced with the more readable isRootLayer() for consistency with the rest of the file.
Attachments
Patch (2.77 KB, patch)
2017-09-08 06:23 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (3.53 KB, patch)
2017-09-08 07:27 PDT, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2017-09-08 06:23:32 PDT
Created attachment 320258 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2017-09-08 07:27:07 PDT
Created attachment 320260 [details] Patch
Frédéric Wang (:fredw)
Comment 3 2017-09-08 08:10:18 PDT
Some part is extracted from Simon's patch for bug 176261
Simon Fraser (smfr)
Comment 4 2017-09-08 10:30:43 PDT
Comment on attachment 320260 [details] Patch I would like to rename isRootLayer() to isRenderViewLayer() at the same time.
Darin Adler
Comment 5 2017-09-10 15:17:44 PDT
(In reply to Simon Fraser (smfr) from comment #4) > I would like to rename isRootLayer() to isRenderViewLayer() Good idea. > at the same time. Seems unnecessary to time it that way. Much bigger than this patch. Should do with do-webcore-rename!
Frédéric Wang (:fredw)
Comment 6 2017-09-10 22:50:28 PDT
Committed r221845: <http://trac.webkit.org/changeset/221845>
Radar WebKit Bug Importer
Comment 7 2017-09-27 12:34:02 PDT
<rdar://problem/34693498>
Note You need to log in before you can comment on or make changes to this bug.