Bug 175909
| Summary: | REGRESSION (r220052): VideoControlsManager.VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling is a flaky API test | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Lewis <jlewis3> |
| Component: | Media | Assignee: | Cameron McCormack (:heycam) <heycam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, heycam, hhjalmarsson, jer.noble, rackler, ryanhaddad, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=175143 https://bugs.webkit.org/show_bug.cgi?id=175329 |
||
Matt Lewis
The API test VideoControlsManager.VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling is a flaky timeout on macOS Sierra.
This test looks to have started to be flaky after r220052 like other tests from VideoControlsManager
Results:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20%28Tests%29/builds/4087/steps/run-api-tests/logs/stdio
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/3798
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Lewis
I was able to confirm the regression point locally by running all of the api tests on a debug build. I was unable to reproduce the timeout when just running the VideoControlsManager test alone.
Disabled the test for now in:
https://trac.webkit.org/changeset/221151/webkit
Radar WebKit Bug Importer
<rdar://problem/42793000>
Cameron McCormack (:heycam)
*** Bug 242043 has been marked as a duplicate of this bug. ***
Cameron McCormack (:heycam)
*** Bug 243675 has been marked as a duplicate of this bug. ***
Cameron McCormack (:heycam)
I'll fix the flakiness of these three tests in this bug:
VideoControlsManager.VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling
VideoControlsManager.VideoControlsManagerMultipleVideosScrollOnlyLargeVideoOutOfView
VideoControlsManager.VideoControlsManagerMultipleVideosScrollPlayingMutedVideoOutOfView
But it turns out VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling is also permanently failing for other reasons. I'll file a separate bug on that after fixing the flakiness.
Cameron McCormack (:heycam)
Pull request: https://github.com/WebKit/WebKit/pull/4843
EWS
Committed 255057@main (f83459d64a06): <https://commits.webkit.org/255057@main>
Reviewed commits have been landed. Closing PR #4843 and removing active labels.