Bug 173433
| Summary: | REGRESSION(r218344): [WPE] Thousands of layout test crashes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> |
| Component: | WPE WebKit | Assignee: | Carlos Alberto Lopez Perez <clopez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, zan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 173483 | ||
| Bug Blocks: | 173061 | ||
Carlos Alberto Lopez Perez
r218344 <http://trac.webkit.org/changeset/218344> caused thousands of layout test crashes due to the update on WPEBackend-mesa on the JHBuild.
My guess is that something is setting a DISPLAY environment there (perhaps the tool driver) and confusing the check for X11.
The bot itself doesn't set that variable.
https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/874/steps/layout-test/logs/stdio
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Alberto Lopez Perez
Committed r218355: <http://trac.webkit.org/changeset/218355>
Carlos Alberto Lopez Perez
I reverted the update on WPEBackend-mesa that triggered this issue. Layout tests are working back as expected on WPE.
Also I identified the issue: we are setting always a DISPLAY environment variable on Tools/Scripts/webkitpy/port/base.py (even when the user environment doesn't have one).
I will upload ASAP a patch to fix this.
Carlos Alberto Lopez Perez
Proposed patch at: bug 173483
Carlos Alberto Lopez Perez
Committed r218491: <http://trac.webkit.org/changeset/218491>