Bug 173483 - Port setup_environ_for_server should not set environment variables related with the driver.
Summary: Port setup_environ_for_server should not set environment variables related wi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks: 173433
  Show dependency tree / graph
 
Reported: 2017-06-16 11:17 PDT by Carlos Alberto Lopez Perez
Modified: 2017-06-19 06:01 PDT (History)
11 users (show)

See Also:

Attachments
Patch (24.88 KB, patch)
2017-06-16 11:41 PDT, Carlos Alberto Lopez Perez 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-06-16 11:17:19 PDT 
On bug 173433 I found that the port setup_environ_for_server() is setting some environment variables (like DISPLAY) that should not be setted there.
Its the job of the driver (on _setup_environ_for_test()) setting that variables.
Comment 1 Carlos Alberto Lopez Perez 2017-06-16 11:41:08 PDT 
Created attachment 313101 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-06-17 00:13:41 PDT 
Comment on attachment 313101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313101&action=review

> Tools/Scripts/webkitpy/port/base.py:871
> +        # Use the driver _setup_environ_for_test() method for that..

Double . at the end.
Comment 3 Carlos Alberto Lopez Perez 2017-06-19 03:39:32 PDT 
Committed r218482: <http://trac.webkit.org/changeset/218482>
Comment 4 Carlos Alberto Lopez Perez 2017-06-19 06:01:28 PDT 
Committed r218490: <http://trac.webkit.org/changeset/218490>