Bug 168693

Summary: Make sampling algorithm more stable and introduce an abstraction for sampled data
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, cdumez, dewei_zhu, joepeck, kling, koivisto, rniwa, slewis
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 168813, 168863    
Attachments:
Description Flags
Patch
none
Removed one more unused function cdumez: review+

Ryosuke Niwa
Reported 2017-02-21 16:39:20 PST
Make the sampling algorithm used in TimeSeriesChart a lot simpler and stable so that changing the window size doesn't result in some points pop up & disappear. With new algorithm which filters data points based on purely time interval, the sampling is always stable. Widening the width of a chart always results in more data points to appear but not hide existing data points. Also introduce an abstraction to represent the sampled time series data so that adding the ability to select baseline, etc... would be easier.
Attachments
Patch (45.89 KB, patch)
2017-02-21 17:21 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed one more unused function (45.70 KB, patch)
2017-02-21 20:15 PST, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-02-21 17:21:22 PST
Created attachment 302346 [details] Patch
Ryosuke Niwa
Comment 2 2017-02-21 20:15:21 PST
Created attachment 302361 [details] Removed one more unused function
Ryosuke Niwa
Comment 3 2017-02-22 14:09:25 PST
Committed r212853: <http://trac.webkit.org/changeset/212853>
Note You need to log in before you can comment on or make changes to this bug.