| Summary: | Move private methods from WKContentObservation.h to a separate header file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | WebCore Misc. | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, juergen, mitz | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=167996 https://bugs.webkit.org/show_bug.cgi?id=167977 |
||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2017-02-08 09:46:04 PST
Created attachment 300920 [details]
Proposed patch
Attachment 300920 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/ios/wak/WKContentObservationInternal.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Only the WKContentChange enum definition needs to be in WebKit SPI headers. I think that as next step, we should move everything else to the Internal header too, and we should make it a private header for WebCore then. Comment on attachment 300920 [details] Proposed patch Clearing flags on attachment: 300920 Committed r211889: <http://trac.webkit.org/changeset/211889> All reviewed patches have been landed. Closing bug. Comment on attachment 300920 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=300920&action=review > Source/WebCore/page/DOMTimer.cpp:50 > #include "WKContentObservation.h" > +#include "WKContentObservationInternal.h" We normally include only the internal header, because it includes the private and public headers as needed. |