Bug 167998

Summary:

Move private methods from WKContentObservation.h to a separate header file

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebCore Misc.

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, juergen, mitz

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=167996
https://bugs.webkit.org/show_bug.cgi?id=167977

Attachments:

Description	Flags
Proposed patch	none

Aakash Jain

Reported 2017-02-08 09:46:04 PST

WKContentObservation.h contains several methods which are used only in WebCore (and need not be exported). However WKContentObservation.h is a private header (not project header). We should move all these methods to a separate header file which would be project header.

Attachments
Proposed patch (9.40 KB, patch) 2017-02-08 10:16 PST, Aakash Jain	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-08 10:16:01 PST

Created attachment 300920 [details] Proposed patch

WebKit Commit Bot

Comment 2 2017-02-08 10:18:50 PST

Attachment 300920 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ios/wak/WKContentObservationInternal.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2017-02-08 11:25:14 PST

Only the WKContentChange enum definition needs to be in WebKit SPI headers. I think that as next step, we should move everything else to the Internal header too, and we should make it a private header for WebCore then.

WebKit Commit Bot

Comment 4 2017-02-08 11:44:22 PST

Comment on attachment 300920 [details] Proposed patch Clearing flags on attachment: 300920 Committed r211889: <http://trac.webkit.org/changeset/211889>

WebKit Commit Bot

Comment 5 2017-02-08 11:44:26 PST

All reviewed patches have been landed. Closing bug.

mitz

Comment 6 2017-02-08 11:46:52 PST

Comment on attachment 300920 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=300920&action=review > Source/WebCore/page/DOMTimer.cpp:50 > #include "WKContentObservation.h" > +#include "WKContentObservationInternal.h" We normally include only the internal header, because it includes the private and public headers as needed.

Note You need to log in before you can comment on or make changes to this bug.