Summary: | Migrate 97 *-disabled tests to be skipped in TestExpectations | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ap, commit-queue, lforschler, ryanhaddad, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | Safari 10 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=20871 https://bugs.webkit.org/show_bug.cgi?id=48454 https://bugs.webkit.org/show_bug.cgi?id=58323 https://bugs.webkit.org/show_bug.cgi?id=19581 https://bugs.webkit.org/show_bug.cgi?id=10993 https://bugs.webkit.org/show_bug.cgi?id=9640 https://bugs.webkit.org/show_bug.cgi?id=7899 |
||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2017-01-27 17:23:17 PST
Ryan/Alexey: I'm happy to do a bulk rename of the files and add them to LayoutTests/TestExpectations, but I don't have time to categorize/sort/retest them. Is it okay just to do the rename/addition, or do you really want them categorized as they go into LayoutTests/TestExpectations? Heh, there's also two resource files: LayoutTests/js/resources/garbage-collect-after-string-appends.js-disabled LayoutTests/svg/W3C-SVG-1.1/resources/filters-comptran-01-f.svg-disabled Not sure if those were renamed with corresponding test files or not. I think that it's fine to just move these to Skipped list; one thing I'd do is add a comment saying that the reasons for disabling these tests should be found in Trac or svn log. Output list of renamed files to a file: $ find LayoutTests -name \*-disabled | sed -e 's/-disabled//' | grep -v '/resources/' > renamed.txt Created attachment 300048 [details]
Patch v1
(In reply to comment #1) > Ryan/Alexey: I'm happy to do a bulk rename of the files and add them to > LayoutTests/TestExpectations, but I don't have time to > categorize/sort/retest them. I categorized them with bug numbers or comments on when/why they were disabled. I ran them a couple times locally with ASan enabled, but there were no interesting crashes. I think roughly half can probably be re-enabled (some marked as slow or flaky), but I don't have time to watch the bots after doing so right now. Created attachment 300050 [details]
List of renamed tests (useful for running just these tests)
$ ./Tools/Scripts/run-webkit-tests --child-processes=4 --fully-parallel --release `cat renamed.txt`
Comment on attachment 300048 [details] Patch v1 Clearing flags on attachment: 300048 Committed r211349: <http://trac.webkit.org/changeset/211349> All reviewed patches have been landed. Closing bug. |