Bug 58323 - compositing/objects/composited-object-alignment.html causing failures in other tests since its introduction in r83518
Summary: compositing/objects/composited-object-alignment.html causing failures in othe...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chris Marrin
URL:
Keywords: InRadar, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2011-04-12 08:26 PDT by Jessie Berlin
Modified: 2024-01-08 06:50 PST (History)
7 users (show)

See Also:

Attachments
Patch (65.53 KB, patch)
2011-04-12 10:45 PDT, Chris Marrin 		simon.fraser: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jessie Berlin 2011-04-12 08:26:59 PDT 
http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r83519%20(11485)/compositing/overflow/ancestor-overflow-pretty-diff.html

The error there is coming from the code in LayoutTests/compositing/objects/resources/composited-subframe.html, which is used by composited-object-alignment, and is a bit buggy:
1)It uses setTimeout without first calling layoutTestController.waitUntilDone.
2)It tries to call some nonexistent parent.testDone() function.
3)The platform-specific results are sitting in the cross-platform directory.

This test should be disabled until it is fixed.
Comment 1 Jessie Berlin 2011-04-12 08:36:36 PDT 
Disabled the test in http://trac.webkit.org/changeset/83588
Comment 2 Adam Roben (:aroben) 2011-04-12 09:29:43 PDT 
<rdar://problem/9271337>
Comment 3 Chris Marrin 2011-04-12 09:53:35 PDT 
(In reply to comment #0)
> http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r83519%20(11485)/compositing/overflow/ancestor-overflow-pretty-diff.html
> 
> The error there is coming from the code in LayoutTests/compositing/objects/resources/composited-subframe.html, which is used by composited-object-alignment, and is a bit buggy:
> 1)It uses setTimeout without first calling layoutTestController.waitUntilDone.
> 2)It tries to call some nonexistent parent.testDone() function.

This is cruft I failed to get rid of when changing the test to do a pixel test rather than printing the layer tree. I'll get rid of it.

> 3)The platform-specific results are sitting in the cross-platform directory.

The intent is for all the results to be cross-platform. I avoided text and borders and anything else that would cause differences in the pixel results.
Comment 4 Chris Marrin 2011-04-12 10:11:33 PDT 
Looks like pixel results don't match up, at least not between WebKit and WebKit2. So I will just generate platform specific results for all cases
Comment 5 Chris Marrin 2011-04-12 10:45:11 PDT 
Created attachment 89224 [details]
Patch
Comment 6 Simon Fraser (smfr) 2011-04-12 10:46:21 PDT 
Comment on attachment 89224 [details]
Patch

Looks like LayoutTests/platform/mac/compositing/objects/composited-object-alignment-expected.png has the wrong mime type.
Comment 7 WebKit Review Bot 2011-06-18 12:04:41 PDT 
Comment on attachment 89224 [details]
Patch

Rejecting attachment 89224 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
annot stat `LayoutTests/compositing/objects/composited-object-alignment-expected.checksum': No such file or directory
Failed to copy LayoutTests/compositing/objects/composited-object-alignment-expected.checksum LayoutTests/platform/mac/compositing/objects/composited-object-alignment-expected.checksum. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 428.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Fraser', u'--for..." exit_code: 2

Full output: http://queues.webkit.org/results/8881917