Summary: | Add the support for ShadowRoot.delegateFocus | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Damiaan Dufaux <damiaan> | ||||||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cdumez, cmarcelo, dbates, esprehn+autocc, ews-watchlist, jan, kangil.han, koivisto, kondapallykalyan, rakina, rniwa, webkit-bug-importer, wenson_hsieh | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Mac | ||||||||||
OS: | macOS 10.12 | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=203869 https://bugs.webkit.org/show_bug.cgi?id=214859 |
||||||||||
Bug Depends on: | 202432, 202497 | ||||||||||
Bug Blocks: | 148695, 202875 | ||||||||||
Attachments: |
|
Description
Damiaan Dufaux
2016-12-26 14:17:13 PST
Created attachment 376241 [details]
WIP
Attachment 376241 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/Element.cpp:2837: 'newTarget' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4]
Total errors found: 1 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 380813 [details]
Adds the support
Comment on attachment 380813 [details] Adds the support View in context: https://bugs.webkit.org/attachment.cgi?id=380813&action=review > Source/WebCore/dom/ShadowRoot.cpp:59 > +ShadowRoot::ShadowRoot(Document& document, ShadowRootMode type, bool delegatesFocus) Please use enum in the interface. The member can be bool. > Source/WebCore/dom/ShadowRoot.h:45 > + enum class FocusDelegation { Yes, No }; You even have one, you are just not using it! (In reply to Antti Koivisto from comment #5) > Comment on attachment 380813 [details] > Adds the support > > View in context: > https://bugs.webkit.org/attachment.cgi?id=380813&action=review > > > Source/WebCore/dom/ShadowRoot.cpp:59 > > +ShadowRoot::ShadowRoot(Document& document, ShadowRootMode type, bool delegatesFocus) > > Please use enum in the interface. The member can be bool. Yeah, I guess I added enum after I had added this argument! > > > Source/WebCore/dom/ShadowRoot.h:45 > > + enum class FocusDelegation { Yes, No }; > > You even have one, you are just not using it! Will do. I also forgot to specify the width again (uint8_t) :( Will fix that. Committed r251043: <https://trac.webkit.org/changeset/251043> Landed the windows build fix in https://trac.webkit.org/changeset/251044. FYI there's one new addition for the spec, to keep the focused element if it's a flat-tree descendant of the host: https://github.com/whatwg/html/pull/5039 (In reply to Rakina Zata Amni from comment #9) > FYI there's one new addition for the spec, to keep the focused element if > it's a flat-tree descendant of the host: > https://github.com/whatwg/html/pull/5039 This kind of already works in WebKit but fixing it fully in https://bugs.webkit.org/show_bug.cgi?id=203869. |