Bug 165850

Summary: Add implementation for navigator.requestMediaKeySystemAccess()
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, cturner, eric.carlson, ipletikosic, pnormand, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 165972, 165823    
Bug Blocks: 158836    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
eric.carlson: review+
Patch for landing
none
Patch for landing
none
Archive of layout-test-results from ews114 for mac-yosemite none

Jer Noble
Reported 2016-12-14 08:25:16 PST
Add implementation for navigator.requestMediaKeySystemAccess()
Attachments
Patch (22.26 KB, patch)
2016-12-14 08:30 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (122.39 KB, patch)
2016-12-16 14:56 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (124.53 KB, patch)
2016-12-16 15:06 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch for landing (124.49 KB, patch)
2016-12-16 23:31 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (124.40 KB, patch)
2016-12-16 23:53 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-yosemite (1.66 MB, application/zip)
2016-12-17 01:07 PST, Build Bot 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-12-14 08:30:45 PST
Created attachment 297091 [details] Patch
Jer Noble
Comment 2 2016-12-16 14:56:38 PST
Created attachment 297360 [details] Patch
Jer Noble
Comment 3 2016-12-16 15:06:35 PST
Created attachment 297362 [details] Patch
Radar WebKit Bug Importer
Comment 4 2016-12-16 15:07:18 PST
<rdar://problem/29714167>
Eric Carlson
Comment 5 2016-12-16 15:34:17 PST
Comment on attachment 297362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297362&action=review r=me once the bots are happy > LayoutTests/media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html:63 > + run('promise = navigator.requestMediaKeySystemAccess("org.webkit.mock", capabilities)'); Nit: extra space here.
Jer Noble
Comment 6 2016-12-16 16:31:01 PST
Looks like an extra reference to JSPositionOptions.cpp snuck in during a rebase.
Jer Noble
Comment 7 2016-12-16 23:31:29 PST
Created attachment 297394 [details] Patch for landing
Jer Noble
Comment 8 2016-12-16 23:53:41 PST
Created attachment 297396 [details] Patch for landing
Build Bot
Comment 9 2016-12-17 01:07:55 PST
Comment on attachment 297396 [details] Patch for landing Attachment 297396 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2742417 New failing tests: http/tests/fetch/fetching-same-resource-with-diffferent-options.html
Build Bot
Comment 10 2016-12-17 01:07:58 PST
Created attachment 297400 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
Jer Noble
Comment 11 2016-12-17 08:54:30 PST
Comment on attachment 297396 [details] Patch for landing Ignoring the commit-bot; this feature is not enabled on mac.
WebKit Commit Bot
Comment 12 2016-12-17 09:19:34 PST
Comment on attachment 297396 [details] Patch for landing Clearing flags on attachment: 297396 Committed r209964: <http://trac.webkit.org/changeset/209964>
Zan Dobersek
Comment 13 2016-12-18 11:05:16 PST
*** Bug 158837 has been marked as a duplicate of this bug. ***
Charlie Turner
Comment 14 2018-07-23 08:11:43 PDT
This has been completed. Closing.
Note You need to log in before you can comment on or make changes to this bug.