Bug 163183

Summary: Convert contributors.json to a flat list
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, ap, commit-queue, ddkilzer, glenn, mcatanzaro, rniwa, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 163478    
Attachments:
Description Flags
Patch
darin: review+
Patch none

Simon Fraser (smfr)
Reported 2016-10-09 12:31:50 PDT
Convert contributors.json to a flat list
Attachments
Patch (276.62 KB, patch)
2016-10-09 12:35 PDT, Simon Fraser (smfr)
darin: review+
Patch (263.97 KB, patch)
2016-10-09 15:55 PDT, Simon Fraser (smfr)
no flags
Simon Fraser (smfr)
Comment 1 2016-10-09 12:35:26 PDT
WebKit Commit Bot
Comment 2 2016-10-09 12:36:10 PDT
Attachment 291050 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2016-10-09 12:40:57 PDT
Any reason it shouldn't just be the highest level of capability per person? No reviewer doesn't also have commit.
Simon Fraser (smfr)
Comment 4 2016-10-09 13:04:33 PDT
Yeah it could be.
Alexey Proskuryakov
Comment 5 2016-10-09 14:05:53 PDT
Should there be a Bugzilla change too here? This file is used for email address auto-complete.
Simon Fraser (smfr)
Comment 6 2016-10-09 15:55:00 PDT
Simon Fraser (smfr)
Comment 7 2016-10-09 15:55:27 PDT
Alexey, will the bugzilla script changes be picked up automatically?
WebKit Commit Bot
Comment 8 2016-10-09 17:27:34 PDT
Attachment 291052 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 9 2016-10-09 17:38:58 PDT
> Alexey, will the bugzilla script changes be picked up automatically? It's been a long time since we made changes to bugzilla, so any auto-update mechanism may have fallen apart. CC'ing David, who should be able to update it manually if needed.
Simon Fraser (smfr)
Comment 10 2016-10-09 17:49:47 PDT
Simon Fraser (smfr)
Comment 11 2016-10-09 17:52:45 PDT
Bugzilla seems to have updated immediately. webkit.org/team not yet updated.
Simon Fraser (smfr)
Comment 12 2016-10-09 23:16:24 PDT
webkit.org/team is working now.
Andy Estes
Comment 13 2016-10-14 17:55:45 PDT
r206973 broke `webkit-patch suggest-reviewers` and `webkit-patch upload --suggest-reviewers`: % webkit-patch suggest-reviewers Traceback (most recent call last): File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 84, in <module> main() File "/Users/andy/Code/OpenSource/Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/tool/steps/suggestreviewers.py", line 45, in run reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit, self._changed_files(state))[:5] File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in suggested_reviewers unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, []) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/checkout/checkout.py", line 146, in <lambda> unique_reviewers = reduce(lambda suggestions, reviewer: suggestions + [reviewer if reviewer not in suggestions else None], reviewers, []) File "/Users/andy/Code/OpenSource/Tools/Scripts/webkitpy/common/config/committers.py", line 79, in __eq__ return (self.full_name == other.full_name AttributeError: 'NoneType' object has no attribute 'full_name'
Andy Estes
Comment 14 2016-10-14 18:24:36 PDT
(In reply to comment #13) > r206973 broke `webkit-patch suggest-reviewers` and `webkit-patch upload > --suggest-reviewers` I filed https://bugs.webkit.org/show_bug.cgi?id=163478
Konstantin Tokarev
Comment 15 2018-01-11 07:33:18 PST
*** Bug 152665 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.