Bug 157110

Summary: Set overflow: hidden on ::-webkit-media-controls in mediaControlsApple.css
Product: WebKit Reporter: Ada Chan <adachan>
Component: MediaAssignee: Ada Chan <adachan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dbates, eric.carlson, mitz, rniwa, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-yosemite
none
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Archive of layout-test-results from ews115 for mac-yosemite
none
Patch eric.carlson: review+

Description Ada Chan 2016-04-27 17:07:09 PDT
This matches how we also set overflow: hidden on ::-webkit-media-controls in mediaControlsiOS.css.  We initially wanted to make this change as part of https://bugs.webkit.org/show_bug.cgi?id=156245, but ran into some layout tests failure/assertions.  

The assertions have been fixed with https://bugs.webkit.org/show_bug.cgi?id=156878.

The image diff difference for fast/regions/inline-block-inside-anonymous-overflow.html has been filed as https://bugs.webkit.org/show_bug.cgi?id=156245 https://bugs.webkit.org/show_bug.cgi?id=156320.  Zalan's recommendation is to mark this test as image-failure-only, and make a copy of that test with the media controls covered up just so we can catch other regressions with this test.
Comment 1 Ada Chan 2016-04-27 17:08:04 PDT
Related to <rdar://problem/25231271>
Comment 2 Ada Chan 2016-04-27 17:31:04 PDT
Created attachment 277555 [details]
Patch
Comment 3 Ada Chan 2016-04-27 17:32:47 PDT
Submitted a patch to EWS to run - I'll probably need to rebaseline some tests.
Comment 4 Build Bot 2016-04-27 17:57:09 PDT
Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1231310

New failing tests:
media/media-document-audio-repaint.html
media/video-zoom-controls.html
Comment 5 Build Bot 2016-04-27 17:57:12 PDT
Created attachment 277561 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-04-27 18:00:16 PDT
Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1231311

New failing tests:
media/media-document-audio-repaint.html
media/video-zoom-controls.html
Comment 7 Build Bot 2016-04-27 18:00:19 PDT
Created attachment 277562 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-04-27 18:25:12 PDT
Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1231389

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html
Comment 9 Build Bot 2016-04-27 18:25:15 PDT
Created attachment 277567 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4
Comment 10 Build Bot 2016-04-27 18:33:25 PDT
Comment on attachment 277555 [details]
Patch

Attachment 277555 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1231400

New failing tests:
media/media-document-audio-repaint.html
media/video-zoom-controls.html
Comment 11 Build Bot 2016-04-27 18:33:28 PDT
Created attachment 277569 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 12 Ada Chan 2016-04-27 22:34:00 PDT
Created attachment 277592 [details]
Patch
Comment 13 Ada Chan 2016-04-28 10:34:49 PDT
Committed:
http://trac.webkit.org/changeset/200196
Comment 14 mitz 2016-05-21 18:46:18 PDT
This caused bug 157975.