Bug 156683

Summary: libjavascriptcoregtk-4.0.dylib is no longer installed
Product: WebKit Reporter: Jeremy Huddleston Sequoia <jeremyhu>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac none

Description Jeremy Huddleston Sequoia 2016-04-17 16:04:13 PDT 
libjavascriptcoregtk-4.0.dylib is not installed by 'make install' in r199646.

Last known good was r198900.

Multiple unrelated build failures plague simple bisection.
Comment 1 Jeremy Huddleston Sequoia 2016-04-17 16:07:44 PDT 
Looks like it was caused by https://bugs.webkit.org/show_bug.cgi?id=156268

More incorrect assumptions that APPLE == Mac.
Comment 2 Jeremy Huddleston Sequoia 2016-04-17 17:09:54 PDT 
Created attachment 276613 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

This patch fixes the issue and is being used now by MacPorts.
Comment 3 Alex Christensen 2016-04-17 23:01:20 PDT 
Comment on attachment 276613 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

My bad
Comment 4 WebKit Commit Bot 2016-04-17 23:52:27 PDT 
Comment on attachment 276613 [details]
0001-Fix-incorrect-assumption-that-APPLE-implies-Mac

Clearing flags on attachment: 276613

Committed r199651: <http://trac.webkit.org/changeset/199651>
Comment 5 WebKit Commit Bot 2016-04-17 23:52:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alex Christensen 2016-04-18 00:08:27 PDT 
There's probably a similar assumption in WebKit2/CMakeLists.txt.
Comment 7 Alex Christensen 2016-04-18 00:14:28 PDT 
(In reply to comment #6)
> There's probably a similar assumption in WebKit2/CMakeLists.txt.
Fixed in https://bugs.webkit.org/show_bug.cgi?id=156679