Bug 154046

Summary: Add SPI to remove individual user scripts or user style sheets
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fred.wang, mitz, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154056, 154103    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch sam: review+

Anders Carlsson
Reported 2016-02-09 14:09:50 PST
Add SPI to remove individual user scripts or user style sheets
Attachments
Patch (13.04 KB, patch)
2016-02-09 14:12 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (13.08 KB, patch)
2016-02-09 14:55 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-02-09 14:12:06 PST
Created attachment 270952 [details] Patch
mitz
Comment 2 2016-02-09 14:37:23 PST
Comment on attachment 270952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270952&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:42 > +@property (nonatomic, readonly, copy) WK_ARRAY(_WKUserStyleSheet *) *_userStyleSheets; This looks new. Why no availability?
Anders Carlsson
Comment 3 2016-02-09 14:43:16 PST
(In reply to comment #2) > Comment on attachment 270952 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270952&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:42 > > +@property (nonatomic, readonly, copy) WK_ARRAY(_WKUserStyleSheet *) *_userStyleSheets; > > This looks new. Why no availability? Oversight on my part. Fixed.
Anders Carlsson
Comment 4 2016-02-09 14:55:28 PST
Created attachment 270955 [details] Patch
Anders Carlsson
Comment 5 2016-02-09 15:04:28 PST
Committed r196341: <http://trac.webkit.org/changeset/196341>
WebKit Commit Bot
Comment 6 2016-02-09 16:53:14 PST
Re-opened since this is blocked by bug 154056
Ryan Haddad
Comment 7 2016-02-09 17:12:12 PST
*** Bug 154052 has been marked as a duplicate of this bug. ***
Ryan Haddad
Comment 8 2016-02-09 17:12:38 PST
3 WKUserContentController API tests were failing on Mac and iOS after this change: Tests that failed: WKUserContentController.AddUserStyleSheetBeforeCreatingView WKUserContentController.UserStyleSheetAffectingAllFrames WKUserContentController.UserStyleSheetAffectingOnlyMainFrame <https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/3215> FAIL WKUserContentController.AddUserStyleSheetBeforeCreatingView /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgb(255, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)" FAIL WKUserContentController.UserStyleSheetAffectingAllFrames /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgb(255, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)" /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgba(0, 0, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)" FAIL WKUserContentController.UserStyleSheetAffectingOnlyMainFrame /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgb(255, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)"
Anders Carlsson
Comment 9 2016-02-10 15:57:31 PST
Committed r196399: <http://trac.webkit.org/changeset/196399>
Frédéric Wang (:fredw)
Comment 10 2016-02-11 01:58:59 PST
(In reply to comment #9) > Committed r196399: <http://trac.webkit.org/changeset/196399> This broke the GTK build.
Note You need to log in before you can comment on or make changes to this bug.