Summary: | Add SPI to remove individual user scripts or user style sheets | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, fred.wang, mitz, ryanhaddad | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 154056, 154103 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Anders Carlsson
2016-02-09 14:09:50 PST
Created attachment 270952 [details]
Patch
Comment on attachment 270952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270952&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:42 > +@property (nonatomic, readonly, copy) WK_ARRAY(_WKUserStyleSheet *) *_userStyleSheets; This looks new. Why no availability? (In reply to comment #2) > Comment on attachment 270952 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270952&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:42 > > +@property (nonatomic, readonly, copy) WK_ARRAY(_WKUserStyleSheet *) *_userStyleSheets; > > This looks new. Why no availability? Oversight on my part. Fixed. Created attachment 270955 [details]
Patch
Committed r196341: <http://trac.webkit.org/changeset/196341> Re-opened since this is blocked by bug 154056 *** Bug 154052 has been marked as a duplicate of this bug. *** 3 WKUserContentController API tests were failing on Mac and iOS after this change: Tests that failed: WKUserContentController.AddUserStyleSheetBeforeCreatingView WKUserContentController.UserStyleSheetAffectingAllFrames WKUserContentController.UserStyleSheetAffectingOnlyMainFrame <https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Tests%29/builds/3215> FAIL WKUserContentController.AddUserStyleSheetBeforeCreatingView /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgb(255, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)" FAIL WKUserContentController.UserStyleSheetAffectingAllFrames /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgb(255, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)" /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgba(0, 0, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)" FAIL WKUserContentController.UserStyleSheetAffectingOnlyMainFrame /Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:276 Value of: value Actual: "rgb(255, 0, 0)" Expected: color Which is: "rgb(0, 128, 0)" Committed r196399: <http://trac.webkit.org/changeset/196399> (In reply to comment #9) > Committed r196399: <http://trac.webkit.org/changeset/196399> This broke the GTK build. |