Bug 152708

Summary: isUntypedSpeculationForArithmetic is wrong
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=152705
Bug Depends on:    
Bug Blocks: 152736    
Attachments:
Description Flags
proposed patch.
fpizlo: review+
x86_64 benchmark result.
none
x86 benchmark result. none

Description Filip Pizlo 2016-01-04 12:26:26 PST 
It will currently return true anytime that the prediction set does not contain numeric types.  That's not correct.
Comment 1 Mark Lam 2016-01-04 14:46:59 PST 
Created attachment 268235 [details]
proposed patch.
Comment 2 Mark Lam 2016-01-04 14:49:09 PST 
Created attachment 268236 [details]
x86_64 benchmark result.
Comment 3 Mark Lam 2016-01-04 14:49:43 PST 
Created attachment 268237 [details]
x86 benchmark result.
Comment 4 Mark Lam 2016-01-04 14:56:12 PST 
Thanks for the review.  Landed in r194560: <http://trac.webkit.org/r194560>.