Bug 151485

Summary: New JSC tests introduced in r192664 fail on ARM
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, ggaren, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108645, 151465    
Attachments:
Description Flags
proposed patch. ggaren: review+

Description Csaba Osztrogonác 2015-11-20 02:37:24 PST
New tests introduced in http://trac.webkit.org/r192664 fail on ARM Linux tester bots. 
Maybe they fail on iOS too, but I don't know, because there is no (public) iOS JSC tester.

32 bit ARM bots:
-----------------
- https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Thumb2%20Release/builds/16232
- https://build.webkit.org/builders/EFL%20Linux%20ARMv7%20Traditional%20Release/builds/16078
- https://build.webkit.org/builders/GTK%20Linux%20ARM%20Release/builds/9401

** The following JSC stress test failures have been introduced:
	stress/op_rshift.js.always-trigger-copy-phase
	stress/op_rshift.js.default
	stress/op_rshift.js.dfg-maximal-flush-validate-no-cjit
	stress/op_rshift.js.no-cjit-validate-phases
	stress/op_rshift.js.no-llint
	stress/op_urshift.js.always-trigger-copy-phase
	stress/op_urshift.js.default
	stress/op_urshift.js.dfg-maximal-flush-validate-no-cjit
	stress/op_urshift.js.no-cjit-validate-phases
	stress/op_urshift.js.no-llint

the 64 bit ARM bot:
--------------------
- https://build.webkit.org/builders/EFL%20Linux%20AArch64%20Release/builds/4437

** The following JSC stress test failures have been introduced:
[snip] (older failures)
	stress/op_div.js.always-trigger-copy-phase
	stress/op_div.js.default
	stress/op_div.js.dfg-eager
	stress/op_div.js.dfg-eager-no-cjit-validate
	stress/op_div.js.dfg-maximal-flush-validate-no-cjit
	stress/op_div.js.no-cjit-validate-phases
	stress/op_div.js.no-llint
[snip] (older failures)
Comment 1 Mark Lam 2015-11-20 13:08:18 PST
I've confirmed the op_div failures on ARM64.  Checking ARMv7 now.
Comment 2 Mark Lam 2015-11-20 14:11:38 PST
I've also confirmed the op_rshift and op_urshift failures on ARMv7.
Comment 3 Mark Lam 2015-11-20 15:13:26 PST
I filed https://bugs.webkit.org/show_bug.cgi?id=151514 to track the ARM32 bugs, and https://bugs.webkit.org/show_bug.cgi?id=151515 to track the ARM64 bug.

I will skip those tests for now.
Comment 4 Mark Lam 2015-11-20 15:16:53 PST
Created attachment 266004 [details]
proposed patch.
Comment 5 Geoffrey Garen 2015-11-20 15:20:59 PST
Comment on attachment 266004 [details]
proposed patch.

r=me
Comment 6 Mark Lam 2015-11-20 15:42:11 PST
Comment on attachment 266004 [details]
proposed patch.

Cancelling commit queue.  Will commit manually.
Comment 7 Mark Lam 2015-11-20 15:46:25 PST
Thanks for the review.  Landed in r192708: <http://trac.webkit.org/r192708>.