Summary: | [EFL] Fix EFL 1.16 with enabled NEON support | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, hs85.jeong, jh718.park, ossy | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 108645, 150228 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2015-11-12 05:16:33 PST
I disabled NEON to fix the build - http://trac.webkit.org/changeset/192360. But it would be great to fix this build issue in upstream EFL. Maybe the following patch fixes this issue: diff --git a/src/lib/ector/software/ector_drawhelper_private.h b/src/lib/ector/software/ector_drawhelper_private.h index d15a8f6..d62830a 100644 --- a/src/lib/ector/software/ector_drawhelper_private.h +++ b/src/lib/ector/software/ector_drawhelper_private.h @@ -11,6 +11,10 @@ #define MAX( a, b ) ( (a) > (b) ? (a) : (b) ) #endif +#ifndef DATA32 +typedef unsigned int DATA32; +#endif + #ifndef uint typedef unsigned int uint; #endif I'll try it later and will submit if it is enough. Created attachment 265585 [details] Patch This patch fixes the EFL NEON build for me, but I'm not sure if it is functionally right or not. I let EFL maintainers to fix this bug themself - https://phab.enlightenment.org/T2851 . (In reply to comment #3) > Created attachment 265585 [details] > Patch > > This patch fixes the EFL NEON build for me, but I'm not sure if it is > functionally right or not. I let EFL maintainers to fix this bug themself - > https://phab.enlightenment.org/T2851 . NEON build was disabled in ector, so we can enable NEON again once 1.16.1 is released or we can add the patch to jhbuild. We already use 1.16.1 since https://trac.webkit.org/changeset/194571 (bug152688) (and 1.17 is coming soon) |