Summary: | Update to match text-orientation spec | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
Component: | Text | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, kojii | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 150766 | ||||||
Bug Blocks: | 150822 | ||||||
Attachments: |
|
Description
Myles C. Maxfield
2015-10-31 20:35:44 PDT
A few comments: * text-orientation: sideways-left is gone, no worry for that. writing-mode: sideways-lr, sideways-rl were added instead, so that we don't have to flip baseline within a single BFC. They're at risk though. * text-combine was updated in both property name and value name, great if you could take care of this change too. (In reply to comment #1) > A few comments: > * text-orientation: sideways-left is gone, no worry for that. writing-mode: > sideways-lr, sideways-rl were added instead, so that we don't have to flip > baseline within a single BFC. They're at risk though. > * text-combine was updated in both property name and value name, great if > you could take care of this change too. Thanks, Koji! I wasn't reading the dev version of the spec. I should make "sideways" a simple alias to "sideways-right". Updating "writing-mode" to match the spec is a different bug. https://bugs.webkit.org/show_bug.cgi?id=150820 Same thing for text-combine: https://bugs.webkit.org/show_bug.cgi?id=150821 Created attachment 264661 [details]
Patch
Comment on attachment 264661 [details] Patch Clearing flags on attachment: 264661 Committed r191953: <http://trac.webkit.org/changeset/191953> All reviewed patches have been landed. Closing bug. |