Bug 149689

Summary: [MSE] Browser crashes when appending invalid data to MSE source buffer
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for landing none

Jer Noble
Reported 2015-09-30 17:40:16 PDT
[MSE] Browser crashes when appending valid data to MSE source buffer
Attachments
Patch (5.77 KB, patch)
2015-09-30 17:42 PDT, Jer Noble 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (5.77 KB, patch)
2015-10-02 08:27 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2015-09-30 17:40:56 PDT
rdar://problem/22152214
Jer Noble
Comment 2 2015-09-30 17:42:48 PDT
Created attachment 262215 [details] Patch
Darin Adler
Comment 3 2015-09-30 21:28:16 PDT
Comment on attachment 262215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262215&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1025 > + if (!segment.audioTracks.size() && !segment.videoTracks.size() && !segment.textTracks.size()) { Would read nicer if you used isEmpty instead of !size.
Jer Noble
Comment 4 2015-10-02 08:27:38 PDT
Created attachment 262332 [details] Patch for landing
WebKit Commit Bot
Comment 5 2015-10-02 12:51:50 PDT
Comment on attachment 262332 [details] Patch for landing Clearing flags on attachment: 262332 Committed r190516: <http://trac.webkit.org/changeset/190516>
Michael Catanzaro
Comment 6 2016-10-16 18:58:19 PDT
It introduced two layout test failures for GTK, see bug #163515 (the new test is failing) and bug #163516 (broke preexisting test). Shame it took a year for us to notice.
Note You need to log in before you can comment on or make changes to this bug.