Bug 149284
| Summary: | Web Inspector: Add UI and settings management logic for SettingsTabContentView | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Baker <mattbaker> |
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bburg, graouts, hi, inspector-bugzilla-changes, ksdshack, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | |||
| Bug Blocks: | 149120, 149261, 149487 | ||
Matt Baker
* SUMMARY
Add UI and settings management logic for SettingsTabContentView. Some things we'll likely need:
- UI/CSS for setting groups (Text Editor, Console, etc), and setting items (toggle, radio/picker, nested settings)
- A manager class for persisting settings, dispatching settings change notifications, storing defaults
- A way to reset all settings to their defaults
* NOTES
This issue covers generic infrastructure only. The addition of specific settings will be tracked by separate issues as needed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/22745863>
Blaze Burg
What is left to do here? Aren't most settings saved as WI.Setting which has events already?
Devin Rousso
(In reply to comment #2)
> What is left to do here? Aren't most settings saved as WI.Setting which has
> events already?
I think this bug was kept open because <https://webkit.org/b/149487> is still open and this bug blocks it. This bug was really a META bug, but never marked as such. Unless anyone has an issue, I think we can close it.
Matt Baker
(In reply to comment #3)
> (In reply to comment #2)
> > What is left to do here? Aren't most settings saved as WI.Setting which has
> > events already?
>
> I think this bug was kept open because <https://webkit.org/b/149487> is
> still open and this bug blocks it. This bug was really a META bug, but
> never marked as such. Unless anyone has an issue, I think we can close it.
Let's close it.