Bug 141870

Summary: Switch remaining CoreMedia soft-linking in WebCore over to CoreMediaSoftLink.{cpp,h}
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=193568
Bug Depends on:    
Bug Blocks: 141625    
Attachments:
Description Flags
Patch v1 (in-progress; checking EWS)
none
Patch v2 (in-progress; checking EWS)
none
Patch v3 (in-progress; checking EWS)
none
Patch v4 (in-progress; checking EWS)
none
Patch v5 (in-progress; checking EWS)
none
Patch v6 (in-progress; checking EWS)
none
Patch v7 (in-progress; checking EWS)
none
Patch v8 (in-progress; checking EWS)
none
Patch v9 (in-progress; checking EWS)
none
Patch v10 (in-progress; checking EWS)
none
Patch v11 (in-progress; checking EWS)
none
Patch v12 (in-progress; checking EWS)
none
Patch v13 (in-progress; checking EWS)
none
Patch v14 (in-progress; checking EWS)
none
Patch v15 (in-progress; checking EWS)
none
Patch v16 (final)
achristensen: review+
Patch for landing none

Description David Kilzer (:ddkilzer) 2015-02-21 14:09:01 PST
Switch remaining CoreMedia soft-linking in WebCore over to CoreMediaSoftLink.{cpp,h}.
Comment 1 David Kilzer (:ddkilzer) 2015-02-21 14:21:52 PST
Created attachment 247058 [details]
Patch v1 (in-progress; checking EWS)
Comment 2 WebKit Commit Bot 2015-02-21 14:23:37 PST
Attachment 247058 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 4 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 David Kilzer (:ddkilzer) 2015-02-21 14:42:16 PST
Created attachment 247059 [details]
Patch v2 (in-progress; checking EWS)
Comment 4 WebKit Commit Bot 2015-02-21 14:44:55 PST
Attachment 247059 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 David Kilzer (:ddkilzer) 2015-02-21 15:13:13 PST
Created attachment 247060 [details]
Patch v3 (in-progress; checking EWS)
Comment 6 WebKit Commit Bot 2015-02-21 15:14:33 PST
Attachment 247060 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 David Kilzer (:ddkilzer) 2015-02-21 15:20:23 PST
Created attachment 247061 [details]
Patch v4 (in-progress; checking EWS)
Comment 8 WebKit Commit Bot 2015-02-21 15:23:34 PST
Attachment 247061 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 David Kilzer (:ddkilzer) 2015-02-21 15:25:20 PST
Created attachment 247062 [details]
Patch v5 (in-progress; checking EWS)
Comment 10 WebKit Commit Bot 2015-02-21 15:26:35 PST
Attachment 247062 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 David Kilzer (:ddkilzer) 2015-02-21 15:42:24 PST
Created attachment 247063 [details]
Patch v6 (in-progress; checking EWS)
Comment 12 WebKit Commit Bot 2015-02-21 15:43:58 PST
Attachment 247063 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 David Kilzer (:ddkilzer) 2015-02-21 16:05:51 PST
Created attachment 247064 [details]
Patch v7 (in-progress; checking EWS)
Comment 14 WebKit Commit Bot 2015-02-21 16:07:02 PST
Attachment 247064 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 David Kilzer (:ddkilzer) 2015-02-21 16:33:11 PST
Created attachment 247065 [details]
Patch v8 (in-progress; checking EWS)
Comment 16 WebKit Commit Bot 2015-02-21 16:34:38 PST
Attachment 247065 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 David Kilzer (:ddkilzer) 2015-02-21 16:52:57 PST
Created attachment 247066 [details]
Patch v9 (in-progress; checking EWS)
Comment 18 WebKit Commit Bot 2015-02-21 16:55:58 PST
Attachment 247066 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 19 David Kilzer (:ddkilzer) 2015-02-21 17:18:54 PST
Created attachment 247067 [details]
Patch v10 (in-progress; checking EWS)
Comment 20 WebKit Commit Bot 2015-02-21 17:21:04 PST
Attachment 247067 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 6 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 21 David Kilzer (:ddkilzer) 2015-02-21 17:28:28 PST
(In reply to comment #20)
> Attachment 247067 [details] did not pass style-queue:
> 
> 
> ERROR:
> Source/WebCore/platform/graphics/avfoundation/objc/
> MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing
> system and custom headers.  [build/include_order] [4]
> ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:50: 
> Bad include order. Mixing system and custom headers.  [build/include_order]
> [4]
> ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48: 
> Bad include order. Mixing system and custom headers.  [build/include_order]
> [4]
> ERROR:
> Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
> 49:  Bad include order. Mixing system and custom headers. 
> [build/include_order] [4]
> ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad
> include order. Mixing system and custom headers.  [build/include_order] [4]
> ERROR:
> Source/WebCore/platform/graphics/avfoundation/objc/
> SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and
> custom headers.  [build/include_order] [4]
> Total errors found: 6 in 14 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Bug 141872 covers fixing these warning messages.
Comment 22 David Kilzer (:ddkilzer) 2015-02-21 19:05:21 PST
Created attachment 247076 [details]
Patch v11 (in-progress; checking EWS)
Comment 23 WebKit Commit Bot 2015-02-21 19:09:22 PST
Attachment 247076 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 24 David Kilzer (:ddkilzer) 2015-02-21 19:23:46 PST
Created attachment 247077 [details]
Patch v12 (in-progress; checking EWS)
Comment 25 WebKit Commit Bot 2015-02-21 19:26:50 PST
Attachment 247077 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 26 David Kilzer (:ddkilzer) 2015-02-21 20:22:36 PST
Created attachment 247078 [details]
Patch v13 (in-progress; checking EWS)
Comment 27 WebKit Commit Bot 2015-02-21 20:24:49 PST
Attachment 247078 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 28 David Kilzer (:ddkilzer) 2015-02-21 20:42:34 PST
Created attachment 247079 [details]
Patch v14 (in-progress; checking EWS)
Comment 29 WebKit Commit Bot 2015-02-21 20:44:03 PST
Attachment 247079 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 30 David Kilzer (:ddkilzer) 2015-02-22 02:34:48 PST
Created attachment 247081 [details]
Patch v15 (in-progress; checking EWS)
Comment 31 WebKit Commit Bot 2015-02-22 02:36:41 PST
Attachment 247081 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:48:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 5 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 32 Darin Adler 2015-02-24 19:37:17 PST
Comment on attachment 247081 [details]
Patch v15 (in-progress; checking EWS)

View in context: https://bugs.webkit.org/attachment.cgi?id=247081&action=review

> Source/WebCore/ChangeLog:8
> +        FIXME: Write ChangeLog once all changes are done.

Should do that.
Comment 33 David Kilzer (:ddkilzer) 2015-03-02 19:41:46 PST
Created attachment 247739 [details]
Patch v16 (final)
Comment 34 WebKit Commit Bot 2015-03-02 19:43:33 PST
Attachment 247739 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:43:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:42:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:49:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/mac/PlatformClockCM.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 7 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 35 David Kilzer (:ddkilzer) 2015-03-02 19:47:56 PST
(In reply to comment #34)
> Attachment 247739 [details] did not pass style-queue:
> 
> 
> ERROR:
> Source/WebCore/platform/graphics/avfoundation/objc/
> MediaPlayerPrivateMediaSourceAVFObjC.mm:50:  Bad include order. Mixing
> system and custom headers.  [build/include_order] [4]
> ERROR: Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm:43: 
> Bad include order. Mixing system and custom headers.  [build/include_order]
> [4]
> ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:42: 
> Bad include order. Mixing system and custom headers.  [build/include_order]
> [4]
> ERROR:
> Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
> 49:  Bad include order. Mixing system and custom headers. 
> [build/include_order] [4]
> ERROR: Source/WebCore/platform/mac/PlatformClockCM.mm:34:  Alphabetical
> sorting problem.  [build/include_order] [4]
> ERROR: Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:54:  Bad
> include order. Mixing system and custom headers.  [build/include_order] [4]
> ERROR:
> Source/WebCore/platform/graphics/avfoundation/objc/
> SourceBufferPrivateAVFObjC.mm:58:  Bad include order. Mixing system and
> custom headers.  [build/include_order] [4]
> Total errors found: 7 in 15 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Patch on Bug 141872 fixes these new false-positive style errors.
Comment 36 Alex Christensen 2015-03-03 10:16:29 PST
Comment on attachment 247739 [details]
Patch v16 (final)

View in context: https://bugs.webkit.org/attachment.cgi?id=247739&action=review

> Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:53
> +// Soft-linking headers must be included last since they #define functions, constants, etc.

Will all these comments be necessary after your style change?  I'd be ok if you left them out.
Comment 37 David Kilzer (:ddkilzer) 2015-03-03 16:21:43 PST
(In reply to comment #36)
> Comment on attachment 247739 [details]
> Patch v16 (final)
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247739&action=review
> 
> > Source/WebCore/Modules/plugins/QuickTimePluginReplacement.mm:53
> > +// Soft-linking headers must be included last since they #define functions, constants, etc.
> 
> Will all these comments be necessary after your style change?  I'd be ok if
> you left them out.

Great point.  Now that Bug 141872 enforces the style checking, they're probably unnecessary.  Will remove before landing.
Comment 38 David Kilzer (:ddkilzer) 2015-03-04 13:30:45 PST
Created attachment 247889 [details]
Patch for landing
Comment 39 Alex Christensen 2015-03-04 13:37:45 PST
Comment on attachment 247889 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=247889&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:47
> -#pragma mark -
> -#pragma mark Soft Linking
> +#pragma mark - Soft Linking

I think this change should not be made.  Leave one line - and one line Soft Linking
Comment 40 David Kilzer (:ddkilzer) 2015-03-04 13:47:02 PST
(In reply to comment #39)
> Comment on attachment 247889 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247889&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:47
> > -#pragma mark -
> > -#pragma mark Soft Linking
> > +#pragma mark - Soft Linking
> 
> I think this change should not be made.  Leave one line - and one line Soft
> Linking

Why?  You get the exact same rendering in Xcode.
Comment 41 Alex Christensen 2015-03-04 13:49:06 PST
Comment on attachment 247889 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=247889&action=review

>>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:47
>>> +#pragma mark - Soft Linking
>> 
>> I think this change should not be made.  Leave one line - and one line Soft Linking
> 
> Why?  You get the exact same rendering in Xcode.

Ok.  No big deal. In it goes!
Comment 42 WebKit Commit Bot 2015-03-04 14:41:49 PST
Comment on attachment 247889 [details]
Patch for landing

Clearing flags on attachment: 247889

Committed r181036: <http://trac.webkit.org/changeset/181036>
Comment 43 David Kilzer (:ddkilzer) 2015-03-04 15:22:11 PST
Moving to RESOLVED/FIXED.  Not sure why the commit bot didn't do that.
Comment 44 David Kilzer (:ddkilzer) 2015-03-04 16:10:38 PST
(In reply to comment #42)
> Comment on attachment 247889 [details]
> Patch for landing
> 
> Clearing flags on attachment: 247889
> 
> Committed r181036: <http://trac.webkit.org/changeset/181036>

Follow-up build fix:
Committed r181049: < http://trac.webkit.org/changeset/181049>
Comment 45 David Kilzer (:ddkilzer) 2015-03-04 17:21:19 PST
(In reply to comment #44)
> (In reply to comment #42)
> > Comment on attachment 247889 [details]
> > Patch for landing
> > 
> > Clearing flags on attachment: 247889
> > 
> > Committed r181036: <http://trac.webkit.org/changeset/181036>
> 
> Follow-up build fix:
> Committed r181049: < http://trac.webkit.org/changeset/181049>

Follow-up Windows build fix:
Committed r181055: <http://trac.webkit.org/changeset/181055>