Summary: | stop using WebCore.exp.in | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
Component: | WebCore Misc. | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 141430, 141452 | ||||||||||
Bug Blocks: | 136172 | ||||||||||
Attachments: |
|
Description
Alex Christensen
2015-02-09 16:46:07 PST
Created attachment 246305 [details]
Patch
Created attachment 246306 [details]
Patch
Created attachment 246345 [details]
Patch
Re-opened since this is blocked by bug 141452 Comment on attachment 246345 [details]
Patch
We shouldn’t make this change before inspecting the differences between what is exported before and after the change. Could you post the list of differences between what is exported by WebCore.framework before and after on at least one platform? (Release, not debug.)
As of 179931, the only difference between the exports of the WebCore framework on Mavericks with this patch is that these two symbols are no longer exported: _wkCreateURLNPasteboardFlavorTypeName _wkCreateURLPasteboardFlavorTypeName They're not used anywhere, so I think there is no problem making the change. Recommitted to https://trac.webkit.org/r179945 (In reply to comment #8) > As of 179931, the only difference between the exports of the WebCore > framework on Mavericks with this patch is that these two symbols are no > longer exported: > > _wkCreateURLNPasteboardFlavorTypeName > _wkCreateURLPasteboardFlavorTypeName > > They're not used anywhere, so I think there is no problem making the change. Good news! Can we follow up by deleting the various WebCore.exp.in files and the sort-export-files scripts? (In reply to comment #11) > Can we follow up by deleting the various WebCore.exp.in files and the > sort-export-files scripts? That's the next step, along with removing the build step of processing WebCore.exp.in. I'll wait a few hours in case this needs to be reverted again for some reason. Then on to Windows! |