Bug 141413

Summary: stop using WebCore.exp.in
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141430, 141452    
Bug Blocks: 136172    
Attachments:
Description Flags
Patch
none
Patch
none
Patch dbates: review+

Description Alex Christensen 2015-02-09 16:46:07 PST
This is the minimal patch to make the switch.  I'll remove WebCore.exp.in, the build steps involved with it, and the style checking of it in a later patch cleaning up.  This will make it easier to revert in case this causes any problems.
Comment 1 Alex Christensen 2015-02-09 16:50:49 PST
Created attachment 246305 [details]
Patch
Comment 2 Alex Christensen 2015-02-09 17:24:12 PST
Created attachment 246306 [details]
Patch
Comment 3 Alex Christensen 2015-02-10 15:10:02 PST
Created attachment 246345 [details]
Patch
Comment 4 Alex Christensen 2015-02-10 16:02:32 PST
https://trac.webkit.org/r179896
Comment 5 Alex Christensen 2015-02-10 16:03:26 PST
https://trac.webkit.org/r179896
Comment 6 WebKit Commit Bot 2015-02-10 17:37:28 PST
Re-opened since this is blocked by bug 141452
Comment 7 Darin Adler 2015-02-10 23:20:02 PST
Comment on attachment 246345 [details]
Patch

We shouldn’t make this change before inspecting the differences between what is exported before and after the change. Could you post the list of differences between what is exported by WebCore.framework before and after on at least one platform? (Release, not debug.)
Comment 8 Alex Christensen 2015-02-11 11:18:48 PST
As of 179931, the only difference between the exports of the WebCore framework on Mavericks with this patch is that these two symbols are no longer exported:

_wkCreateURLNPasteboardFlavorTypeName
_wkCreateURLPasteboardFlavorTypeName

They're not used anywhere, so I think there is no problem making the change.
Comment 9 Alex Christensen 2015-02-11 12:30:45 PST
Recommitted to https://trac.webkit.org/r179945
Comment 10 Darin Adler 2015-02-11 12:41:43 PST
(In reply to comment #8)
> As of 179931, the only difference between the exports of the WebCore
> framework on Mavericks with this patch is that these two symbols are no
> longer exported:
> 
> _wkCreateURLNPasteboardFlavorTypeName
> _wkCreateURLPasteboardFlavorTypeName
> 
> They're not used anywhere, so I think there is no problem making the change.

Good news!
Comment 11 Darin Adler 2015-02-11 12:42:27 PST
Can we follow up by deleting the various WebCore.exp.in files and the sort-export-files scripts?
Comment 12 Alex Christensen 2015-02-11 12:43:45 PST
(In reply to comment #11)
> Can we follow up by deleting the various WebCore.exp.in files and the
> sort-export-files scripts?
That's the next step, along with removing the build step of processing WebCore.exp.in.  I'll wait a few hours in case this needs to be reverted again for some reason.  Then on to Windows!