| Summary: | run-jsc-stress-tests should pass JSC_timeout to remote hosts | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
| Component: | New Bugs | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, fpizlo, ggaren, mark.lam, mhahnenb, msaboff, oliver, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 141079, 141165 | ||||||
| Attachments: |
|
||||||
|
Description
Csaba Osztrogonác
2015-02-02 11:01:53 PST
Created attachment 245886 [details]
Patch
Comment on attachment 245886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245886&action=review > Tools/Scripts/run-jsc-stress-tests:1364 > + remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && " > + remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && " > + remoteScript += "sh runscript\"" I think if you're going to export these you should also unset them after executing the runscript or something. (In reply to comment #2) > Comment on attachment 245886 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245886&action=review > > > Tools/Scripts/run-jsc-stress-tests:1364 > > + remoteScript += "export DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" && " > > + remoteScript += "export JSC_timeout=#{Shellwords.shellescape(ENV['JSC_timeout'])} && " > > + remoteScript += "sh runscript\"" > > I think if you're going to export these you should also unset them after > executing the runscript or something. These exports are valid for this ssh command and its child processes, they are reset automatically after the command finished. ping? Dear reviewers, could you possibly review this patch? Comment on attachment 245886 [details] Patch Clearing flags on attachment: 245886 Committed r179930: <http://trac.webkit.org/changeset/179930> All reviewed patches have been landed. Closing bug. |