Bug 141079

Summary:

Make run-jsc-stress-tests --remote work with make-based runner

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, fpizlo, ggaren, mark.lam, mhahnenb, msaboff, oliver, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

141164, 141196

Bug Blocks:

141165

Attachments:

Description	Flags
WIP patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Csaba Osztrogonác

Reported 2015-01-30 05:25:45 PST

run-jsc-stress-tests supports a make-based runner and a shell-based runner. For local run both of them are supported. The goal is to make the make-based runner work (optionally) for remote testing too. It is much more faster than the shell-based runner and make is available on Linux, we can use it.

Attachments
WIP patch (4.17 KB, patch) 2015-01-30 05:37 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch (12.36 KB, patch) 2015-02-03 09:27 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch (2.60 KB, patch) 2015-02-03 09:30 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch (6.79 KB, patch) 2015-02-03 09:32 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Patch (6.79 KB, patch) 2015-02-11 09:54 PST, Csaba Osztrogonác	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Csaba Osztrogonác

Comment 1 2015-01-30 05:37:35 PST

Created attachment 245713 [details] WIP patch

Csaba Osztrogonác

Comment 2 2015-01-30 05:43:18 PST

Comment on attachment 245713 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=245713&action=review > Tools/Scripts/run-jsc-stress-tests:-191 > when '--remote' > $copyVM = true > - $testRunnerType = :shell Now the default runner type is shell, which is good for iOS, but bad for Linux. But with this change, the default is make, which is good for Linux, but bad for iOS. I'm going to find a good way to have different default runner types based on OS or add some autodetection mechanism: use make if it is available, otherwise use shell. > Tools/Scripts/run-jsc-stress-tests:1408 > + remoteScript += "DYLD_FRAMEWORK_PATH=\\\"\\$(cd #{$testingFrameworkPath.dirname}; pwd)\\\" make -j4 -s -f Makefile" I'm going to find how to detect / set number of parallel tasks properly instead of hard coding.

Csaba Osztrogonác

Comment 3 2015-02-03 08:39:19 PST

new bug report for processor number detection: bug141196

Csaba Osztrogonác

Comment 4 2015-02-03 09:27:49 PST

Created attachment 245943 [details] Patch Complete patch, it depends on fix in bug141196 and bug141164. I'll set r? once these fixes landed.

Csaba Osztrogonác

Comment 5 2015-02-03 09:28:24 PST

Comment on attachment 245943 [details] Patch wrong patch

Csaba Osztrogonác

Comment 6 2015-02-03 09:30:54 PST

Created attachment 245944 [details] Patch

Csaba Osztrogonác

Comment 7 2015-02-03 09:31:27 PST

Comment on attachment 245944 [details] Patch webkit-patch upload is crazy :-/

Csaba Osztrogonác

Comment 8 2015-02-03 09:32:25 PST

Created attachment 245945 [details] Patch

Csaba Osztrogonác

Comment 9 2015-02-11 09:54:31 PST

Created attachment 246394 [details] Patch

WebKit Commit Bot

Comment 10 2015-02-11 12:31:30 PST

Comment on attachment 246394 [details] Patch Clearing flags on attachment: 246394 Committed r179946: <http://trac.webkit.org/changeset/179946>

WebKit Commit Bot

Comment 11 2015-02-11 12:31:34 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.