Summary: | Fix Unused parameter warning in Webcore bindings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shivakumar J M <shiva.jm> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, darin, gyuyoung.kim, kling, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 140105 | ||||||
Attachments: |
|
Description
Shivakumar J M
2015-01-06 02:15:25 PST
Created attachment 244042 [details]
Patch
remove the Unused parameter from createScriptInstanceForWidget() function.
Comment on attachment 244042 [details]
Patch
LGTM
Comment on attachment 244042 [details] Patch Clearing flags on attachment: 244042 Committed r177954: <http://trac.webkit.org/changeset/177954> All reviewed patches have been landed. Closing bug. Comment on attachment 244042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244042&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=140046 Wrong bug ID... *** Bug 140120 has been marked as a duplicate of this bug. *** (In reply to comment #5) > Comment on attachment 244042 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244042&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=140046 > > Wrong bug ID... I filed a new bug report to fix the CQ not to land patches with this kind of problems: bug140122 Update the changelog in patch: https://bugs.webkit.org/show_bug.cgi?id=140121 Committed r177956: <http://trac.webkit.org/changeset/177956> |