Bug 140118

Summary: Fix Unused parameter warning in Webcore bindings
Product: WebKit Reporter: Shivakumar J M <shiva.jm>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, gyuyoung.kim, kling, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 140105    
Attachments:
Description Flags
Patch none

Shivakumar J M
Reported 2015-01-06 02:15:25 PST
Got build warning error for efl port. might caused by issue: https://bugs.webkit.org/show_bug.cgi?id=140105 ../../Source/WebCore/bindings/js/ScriptController.cpp:408:37: warning: unused parameter ‘widget’ [-Wunused-parameter] PassRefPtr<JSC::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget) ^
Attachments
Patch (1.32 KB, patch)
2015-01-06 02:21 PST, Shivakumar J M 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shivakumar J M
Comment 1 2015-01-06 02:21:13 PST
Created attachment 244042 [details] Patch remove the Unused parameter from createScriptInstanceForWidget() function.
Gyuyoung Kim
Comment 2 2015-01-06 02:30:09 PST
Comment on attachment 244042 [details] Patch LGTM
WebKit Commit Bot
Comment 3 2015-01-06 03:10:07 PST
Comment on attachment 244042 [details] Patch Clearing flags on attachment: 244042 Committed r177954: <http://trac.webkit.org/changeset/177954>
WebKit Commit Bot
Comment 4 2015-01-06 03:10:12 PST
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 5 2015-01-06 03:21:10 PST
Comment on attachment 244042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244042&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=140046 Wrong bug ID...
Csaba Osztrogonác
Comment 6 2015-01-06 03:30:04 PST
*** Bug 140120 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 7 2015-01-06 03:34:39 PST
(In reply to comment #5) > Comment on attachment 244042 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=244042&action=review > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=140046 > > Wrong bug ID... I filed a new bug report to fix the CQ not to land patches with this kind of problems: bug140122
Shivakumar J M
Comment 8 2015-01-06 03:46:34 PST
Update the changelog in patch: https://bugs.webkit.org/show_bug.cgi?id=140121
Gyuyoung Kim
Comment 9 2015-01-06 03:59:53 PST
Committed r177956: <http://trac.webkit.org/changeset/177956>
Note You need to log in before you can comment on or make changes to this bug.