Bug 140118 - Fix Unused parameter warning in Webcore bindings
Summary: Fix Unused parameter warning in Webcore bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 140120 (view as bug list)
Depends on:
Blocks: 140105
  Show dependency tree / graph
 
Reported: 2015-01-06 02:15 PST by Shivakumar J M
Modified: 2015-01-06 03:59 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2015-01-06 02:21 PST, Shivakumar J M 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shivakumar J M 2015-01-06 02:15:25 PST 
Got build warning error for efl port. might caused by issue:  https://bugs.webkit.org/show_bug.cgi?id=140105

../../Source/WebCore/bindings/js/ScriptController.cpp:408:37: warning: unused parameter ‘widget’ [-Wunused-parameter]
 PassRefPtr<JSC::Bindings::Instance> ScriptController::createScriptInstanceForWidget(Widget* widget)
                                     ^
Comment 1 Shivakumar J M 2015-01-06 02:21:13 PST 
Created attachment 244042 [details]
Patch

remove the Unused parameter from createScriptInstanceForWidget() function.
Comment 2 Gyuyoung Kim 2015-01-06 02:30:09 PST 
Comment on attachment 244042 [details]
Patch

LGTM
Comment 3 WebKit Commit Bot 2015-01-06 03:10:07 PST 
Comment on attachment 244042 [details]
Patch

Clearing flags on attachment: 244042

Committed r177954: <http://trac.webkit.org/changeset/177954>
Comment 4 WebKit Commit Bot 2015-01-06 03:10:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Philippe Normand 2015-01-06 03:21:10 PST 
Comment on attachment 244042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244042&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=140046

Wrong bug ID...
Comment 6 Csaba Osztrogonác 2015-01-06 03:30:04 PST 
*** Bug 140120 has been marked as a duplicate of this bug. ***
Comment 7 Csaba Osztrogonác 2015-01-06 03:34:39 PST 
(In reply to comment #5)
> Comment on attachment 244042 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=244042&action=review
> 
> > Source/WebCore/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=140046
> 
> Wrong bug ID...

I filed a new bug report to fix the CQ not to land patches
with this kind of problems: bug140122
Comment 8 Shivakumar J M 2015-01-06 03:46:34 PST 
Update the changelog in patch: https://bugs.webkit.org/show_bug.cgi?id=140121
Comment 9 Gyuyoung Kim 2015-01-06 03:59:53 PST 
Committed r177956: <http://trac.webkit.org/changeset/177956>