WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
140046
Modernize and streamline HTMLToken and AtomicHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=140046
Summary
Modernize and streamline HTMLToken and AtomicHTMLToken
Darin Adler
Reported
2015-01-02 13:19:47 PST
Modernize and streamline HTMLToken and AtomicHTMLToken
Attachments
Patch
(65.49 KB, patch)
2015-01-02 13:34 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(68.88 KB, patch)
2015-01-04 11:48 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews100 for mac-mountainlion
(549.01 KB, application/zip)
2015-01-04 12:33 PST
,
Build Bot
no flags
Details
Archive of layout-test-results from ews106 for mac-mountainlion-wk2
(551.22 KB, application/zip)
2015-01-04 12:37 PST
,
Build Bot
no flags
Details
Patch
(74.04 KB, patch)
2015-01-04 15:40 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(74.17 KB, patch)
2015-01-05 00:36 PST
,
Darin Adler
no flags
Details
Formatted Diff
Diff
Patch
(74.19 KB, patch)
2015-01-05 09:34 PST
,
Darin Adler
kling
: review+
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2015-01-02 13:34:17 PST
Created
attachment 243908
[details]
Patch
Darin Adler
Comment 2
2015-01-04 11:48:17 PST
Created
attachment 243932
[details]
Patch
Build Bot
Comment 3
2015-01-04 12:33:35 PST
Comment on
attachment 243932
[details]
Patch
Attachment 243932
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/6469179959934976
New failing tests: html5lib/generated/run-tests6-write.html fast/preloader/first-base-tag-scanned-wins.html html5lib/generated/run-tests6-data.html html5lib/generated/run-doctype01-write.html html5lib/generated/run-doctype01-data.html fast/preloader/understands-base-tag.html
Build Bot
Comment 4
2015-01-04 12:33:38 PST
Created
attachment 243937
[details]
Archive of layout-test-results from ews100 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 5
2015-01-04 12:36:59 PST
Comment on
attachment 243932
[details]
Patch
Attachment 243932
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/5813054985994240
New failing tests: html5lib/generated/run-tests6-write.html fast/preloader/first-base-tag-scanned-wins.html html5lib/generated/run-tests6-data.html html5lib/generated/run-doctype01-write.html html5lib/generated/run-doctype01-data.html fast/preloader/understands-base-tag.html
Build Bot
Comment 6
2015-01-04 12:37:02 PST
Created
attachment 243939
[details]
Archive of layout-test-results from ews106 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Darin Adler
Comment 7
2015-01-04 15:40:06 PST
Created
attachment 243943
[details]
Patch
Darin Adler
Comment 8
2015-01-04 16:24:44 PST
This patch is now ready for review. The failures on the Mac and Mac-WK2 bots are a problem unrelated to this patch that I believe Antti has just fixed.
Darin Adler
Comment 9
2015-01-05 00:36:31 PST
Created
attachment 243966
[details]
Patch
Darin Adler
Comment 10
2015-01-05 09:34:52 PST
Created
attachment 243979
[details]
Patch
Andreas Kling
Comment 11
2015-01-05 10:34:15 PST
Comment on
attachment 243979
[details]
Patch r=me
Darin Adler
Comment 12
2015-01-06 00:06:10 PST
Committed
r177952
: <
http://trac.webkit.org/changeset/177952
>
Csaba Osztrogonác
Comment 13
2015-01-06 03:25:54 PST
***
Bug 140120
has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 14
2015-01-06 08:30:28 PST
(In reply to
comment #12
)
> Committed
r177952
: <
http://trac.webkit.org/changeset/177952
>
It broke the Apple Windows build: 1>c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\html\parser\HTMLToken.h(387): error C3083: '{ctor}': the symbol to the left of a '::' must be a type (..\loader\TextResourceDecoder.cpp) 1>c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\html\parser\HTMLToken.h(388): error C2533: 'WebCore::HTMLToken::appendToAttributeValue' : constructors not allowed a return type (..\loader\TextResourceDecoder.cpp) 1>c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\html\parser\HTMLToken.h(395): error C3083: '{ctor}': the symbol to the left of a '::' must be a type (..\loader\TextResourceDecoder.cpp) 1>c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\html\parser\HTMLToken.h(396): error C2533: 'WebCore::HTMLToken::appendToAttributeValue' : constructors not allowed a return type (..\loader\TextResourceDecoder.cpp) But unfortunately you didn't have any chance to notice it before landing, because the Windows EWS didn't work since 2.5 weeks. Additionally you didn't have any chance to notice it after landing, because Anders broke the Windows build (
bug140103
) and nobody fixed it yet.
Brent Fulgham
Comment 15
2015-01-06 08:58:15 PST
(In reply to
comment #14
)
> But unfortunately you didn't have any chance to notice it before landing, > because the Windows EWS didn't work since 2.5 weeks. Additionally you > didn't have any chance to notice it after landing, because Anders broke > the Windows build (
bug140103
) and nobody fixed it yet.
Windows EWS bots are back up and working now, but they are currently failing to process patches due to the build errors you mentioned. I've fixed anders' build error (this morning), and will take a look at this new build failure now.
Brent Fulgham
Comment 16
2015-01-06 09:02:10 PST
Comment on
attachment 243979
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=243979&action=review
> Source/WebCore/html/parser/HTMLToken.h:387 > +inline void HTMLToken::HTMLToken::appendToAttributeValue(UChar character)
MSVC chokes on this syntax. It wants HTMLToken::appendToAttributeValue.
> Source/WebCore/html/parser/HTMLToken.h:395 > +inline void HTMLToken::HTMLToken::appendToAttributeValue(unsigned i, StringView value)
Ditto above -- MSVC rejects the use of HTMLToken::HTMLToken::{name}
Darin Adler
Comment 17
2015-01-06 10:55:54 PST
Oops! Thanks for fixing that.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug