Bug 140103 - Add copies of NPN_Evaluate and NPN_Invoke on Windows
Summary: Add copies of NPN_Evaluate and NPN_Invoke on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-05 15:51 PST by Anders Carlsson
Modified: 2015-01-06 08:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2015-01-05 15:55 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-01-05 15:51:25 PST 
Add a copy of NPN_Evaluate and NPN_Invoke on Windows
Comment 1 Anders Carlsson 2015-01-05 15:55:35 PST 
Created attachment 244014 [details]
Patch
Comment 2 Andreas Kling 2015-01-05 16:08:53 PST 
Comment on attachment 244014 [details]
Patch

Gross. Fine, whatever. rs=me
Comment 3 Anders Carlsson 2015-01-05 16:10:54 PST 
Committed r177937: <http://trac.webkit.org/changeset/177937>
Comment 4 Brent Fulgham 2015-01-05 18:02:24 PST 
Some build fixes were needed:

http://trac.webkit.org/changeset/177943.
Comment 5 Brent Fulgham 2015-01-05 18:46:39 PST 
Attempted to fix in:

<http://trac.webkit.org/changeset/177943>.

But finally got it right in: 

<http://trac.webkit.org/changeset/177945>.
Comment 6 Csaba Osztrogonác 2015-01-05 23:53:47 PST 
The Windows build is still broken.
Comment 7 Brent Fulgham 2015-01-06 08:52:57 PST 
One more change was needed:

<http://trac.webkit.org/changeset/177959>