Bug 140105 - Stop including PluginView.h from cross platform WebCore code
Summary: Stop including PluginView.h from cross platform WebCore code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 140118 140120
Blocks:
  Show dependency tree / graph
 
Reported: 2015-01-05 16:57 PST by Anders Carlsson
Modified: 2015-01-06 03:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.25 KB, patch)
2015-01-05 16:58 PST, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (6.61 KB, patch)
2015-01-05 17:12 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-01-05 16:57:45 PST 
Stop including PluginView.h from cross platform WebCore code
Comment 1 Anders Carlsson 2015-01-05 16:58:48 PST 
Created attachment 244017 [details]
Patch
Comment 2 WebKit Commit Bot 2015-01-05 17:00:41 PST 
Attachment 244017 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/NP_jsobject.cpp:254:  _NPN_Evaluate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2015-01-05 17:12:02 PST 
Created attachment 244018 [details]
Patch
Comment 4 WebKit Commit Bot 2015-01-05 17:14:42 PST 
Attachment 244018 [details] did not pass style-queue:


ERROR: Source/WebCore/bridge/NP_jsobject.cpp:254:  _NPN_Evaluate is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Anders Carlsson 2015-01-05 17:23:41 PST 
Committed r177941: <http://trac.webkit.org/changeset/177941>