Bug 139818

Summary: Clean up a fix for performance test bot failing to build
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, lforschler, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=139811
https://bugs.webkit.org/show_bug.cgi?id=139786
Attachments:
Description Flags
proposed patch ossy: review+

Description Alexey Proskuryakov 2014-12-19 09:42:26 PST 
Alexey Proskuryakov 2014-12-19 00:34:28 PST
I now think that the cleanest fix would be to set is_clean in these two before calling Factory.__init__. With this, CleanBuildIfScheduled would clean the directory at the right time.

Comment 5 Ryosuke Niwa 2014-12-19 00:37:43 PST
Or pass in --no-build to run-perf-tests...
Comment 1 Alexey Proskuryakov 2014-12-19 09:45:12 PST 
Created attachment 243554 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2014-12-19 09:50:21 PST 
Comment on attachment 243554 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243554&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:711
> +    # FIXME: Can all ports use --no-build? Everything appears to be either downloaded
> +    # or built locally before running this step.
> +    if platform == 'mac':
> +        self.setCommand(self.command + ['--no-build'])

We can do it unconditionally, EFL and GTK build everything it one shot,
build-webkittestrunner simply returns 0 without doing anything.
Comment 3 Csaba Osztrogonác 2014-12-19 09:53:21 PST 
Comment on attachment 243554 [details]
proposed patch

r=me with the change suggested.
Comment 4 Alexey Proskuryakov 2014-12-19 09:59:06 PST 
Committed <http://trac.webkit.org/r177575>.

We'll need to see if this affects what happens when builds are broken in any strange ways. Seems like it shouldn't though.