Bug 139818

Summary: Clean up a fix for performance test bot failing to build
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, lforschler, ossy, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=139811
https://bugs.webkit.org/show_bug.cgi?id=139786
Attachments:
Description Flags
proposed patch ossy: review+

Alexey Proskuryakov
Reported 2014-12-19 09:42:26 PST
Alexey Proskuryakov 2014-12-19 00:34:28 PST I now think that the cleanest fix would be to set is_clean in these two before calling Factory.__init__. With this, CleanBuildIfScheduled would clean the directory at the right time. Comment 5 Ryosuke Niwa 2014-12-19 00:37:43 PST Or pass in --no-build to run-perf-tests...
Attachments
proposed patch (3.49 KB, patch)
2014-12-19 09:45 PST, Alexey Proskuryakov 		ossy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-12-19 09:45:12 PST
Created attachment 243554 [details] proposed patch
Csaba Osztrogonác
Comment 2 2014-12-19 09:50:21 PST
Comment on attachment 243554 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=243554&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:711 > + # FIXME: Can all ports use --no-build? Everything appears to be either downloaded > + # or built locally before running this step. > + if platform == 'mac': > + self.setCommand(self.command + ['--no-build']) We can do it unconditionally, EFL and GTK build everything it one shot, build-webkittestrunner simply returns 0 without doing anything.
Csaba Osztrogonác
Comment 3 2014-12-19 09:53:21 PST
Comment on attachment 243554 [details] proposed patch r=me with the change suggested.
Alexey Proskuryakov
Comment 4 2014-12-19 09:59:06 PST
Committed <http://trac.webkit.org/r177575>. We'll need to see if this affects what happens when builds are broken in any strange ways. Seems like it shouldn't though.
Note You need to log in before you can comment on or make changes to this bug.