Bug 139811

Summary: REGRESSION(r177535): It broke the GTK performance bot
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Blocker CC: ap, cgarcia, clopez, lforschler, ossy, rniwa
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=139818
Bug Depends on:    
Bug Blocks: 139786    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2014-12-19 00:10:44 PST
After http://trac.webkit.org/r177535 performance bots remove WebKitBuild directory unconditionally. It was a workaround to fix a Mac only issue, but it broke the GTK bot: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/1522 5.) jhbuild updated gtk dependencies 6.) delete WebKitBuild directory_1 deleted WebKitBuild directory --> It removes the necessary dependencies built by step 5.) This clean build is incorrect and unnecessary on the GTK bot.
Attachments
Patch (2.34 KB, patch)
2014-12-19 00:15 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2014-12-19 00:15:51 PST
Created attachment 243547 [details] Patch
Csaba Osztrogonác
Comment 2 2014-12-19 00:24:21 PST
Comment on attachment 243547 [details] Patch Clearing flags on attachment: 243547 Committed r177569: <http://trac.webkit.org/changeset/177569>
Csaba Osztrogonác
Comment 3 2014-12-19 00:24:28 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2014-12-19 00:34:28 PST
I now think that the cleanest fix would be to set is_clean in these two before calling Factory.__init__. With this, CleanBuildIfScheduled would clean the directory at the right time.
Ryosuke Niwa
Comment 5 2014-12-19 00:37:43 PST
Or pass in --no-build to run-perf-tests...
Csaba Osztrogonác
Comment 6 2014-12-19 00:44:45 PST
(In reply to comment #2) > Comment on attachment 243547 [details] > Patch > > Clearing flags on attachment: 243547 > > Committed r177569: <http://trac.webkit.org/changeset/177569> Lucas or Ryosuke, could you possibly push this change to buildmaster and then restart to fix the GTK performance bot? Thanks.
Lucas Forschler
Comment 7 2014-12-19 08:02:14 PST
I've restarted the master, let me know if things don't look correct.
Csaba Osztrogonác
Comment 8 2014-12-19 08:25:03 PST
(In reply to comment #7) > I've restarted the master, let me know if things don't look correct. Thanks, the GTK performance bot is happy now. :)
Darin Adler
Comment 9 2014-12-20 19:39:00 PST
Comment on attachment 243547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243547&action=review > Tools/ChangeLog:8 > + Trigger clean build only on mac platform. Why? If the problem is on GTK, then why isn’t the condition here about GTK, rather than Mac?
Darin Adler
Comment 10 2014-12-20 19:40:08 PST
Comment on attachment 243547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243547&action=review >> Tools/ChangeLog:8 >> + Trigger clean build only on mac platform. > > Why? If the problem is on GTK, then why isn’t the condition here about GTK, rather than Mac? I guess it’s not an important question; looks like Alexey removed this code a few commits later.
Note You need to log in before you can comment on or make changes to this bug.