Bug 139786

Summary:

Perf tests frequently fail saying "build not up to date"

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dburkart, lforschler, ossy, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=139818

Bug Depends on:

139811

Bug Blocks:

Attachments:

Description	Flags
proposed fix	rniwa: review+
proposed re-fix	none

Alexey Proskuryakov

Reported 2014-12-18 12:10:39 PST

E.g.: https://build.webkit.org/builders/Apple%20MountainLion%20Release%20%28Perf%29/builds/10909/steps/perf-test/logs/stdio CompileC /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.o mac/EditingDelegate.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler cd /Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/DumpRenderTree export LANG=en_US.US-ASCII /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu++11 -stdlib=libc++ -Wno-trigraphs -fno-rtti -fpascal-strings -Os -Werror -Wno-missing-field-initializers -Wno-missing-prototypes -Wno-return-type -Wno-implicit-atomic-properties -Wno-receiver-is-weak -Wno-arc-repeated-use-of-weak -Wno-non-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wno-empty-body -Wno-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wno-constant-conversion -Wno-int-conversion -Wno-bool-conversion -Wno-enum-conversion -Wno-shorten-64-to-32 -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DNDEBUG -DENABLE_DASHBOARD_SUPPORT -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wno-deprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.8 -g -Wno-sign-conversion -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/DumpRenderTree.hmap -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/include -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/usr/local/include -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/WebCoreTestSupport -IForwardingHeaders -Imac/InternalHeaders -I/usr/local/include/WebCoreTestSupport -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/DumpRenderTree/../../Source/JavaScriptCore/icu -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/DerivedSources/x86_64 -I/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/DerivedSources -Wall -W -Wno-unused-parameter -Wundef -F/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/Quartz.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/ApplicationServices.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk/System/Library/Frameworks/WebKit.framework/Frameworks -include /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/PrecompiledHeaders/DumpRenderTreePrefix-eznzwvgtqfndrdhafdiqkocjvhoa/DumpRenderTreePrefix.h -MMD -MT dependencies -MF /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.d --serialize-diagnostics /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.dia -c /Volumes/Data/slave/mountainlion-release-perf-tests/build/Tools/DumpRenderTree/mac/EditingDelegate.mm -o /Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/EditingDelegate.o fatal error: file '/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/Release/usr/local/include/wtf/FeatureDefines.h' has been modified since the precompiled header '/Volumes/Data/slave/mountainlion-release-perf-tests/build/WebKitBuild/PrecompiledHeaders/DumpRenderTreePrefix-eznzwvgtqfndrdhafdiqkocjvhoa/DumpRenderTreePrefix.h.pch' was built 1 error generated.

Attachments
proposed fix (4.24 KB, patch) 2014-12-18 12:17 PST, Alexey Proskuryakov	rniwa: review+	Details Formatted Diff Diff
proposed re-fix (4.99 KB, patch) 2014-12-18 15:14 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2014-12-18 12:17:17 PST

Created attachment 243512 [details] proposed fix

Alexey Proskuryakov

Comment 2 2014-12-18 14:51:50 PST

Committed <http://trac.webkit.org/r177529>.

Alexey Proskuryakov

Comment 3 2014-12-18 15:07:57 PST

Comment on attachment 243512 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=243512&action=review > Tools/ChangeLog:12 > + Also, removed unused "build and perf test" code. This were actually used, just under a different name (string manipulation for class name === evil). Rolled out this part in r177533.

Alexey Proskuryakov

Comment 4 2014-12-18 15:12:12 PST

More fixes needed.

Alexey Proskuryakov

Comment 5 2014-12-18 15:14:39 PST

Created attachment 243523 [details] proposed re-fix

Lucas Forschler

Comment 6 2014-12-18 15:17:20 PST

looks good to me.

Alexey Proskuryakov

Comment 7 2014-12-18 15:22:59 PST

Committed <http://trac.webkit.org/r177535>.

Ryosuke Niwa

Comment 8 2014-12-18 15:37:48 PST

Retroactively r=me.

Note You need to log in before you can comment on or make changes to this bug.