Bug 138510

Summary: Fix an alignment issue with operationPushCatchScope on ARMv7
Product: WebKit Reporter: Dániel Bátyai <dbatyai.u-szeged>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, msaboff, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 138254    
Bug Blocks: 108645    
Attachments:
Description Flags
Patch none

Dániel Bátyai
Reported 2014-11-07 11:42:57 PST
A previous patch caused a regression on some ARMv7 platforms. Call arguments were set up differently than how the callee expected them.
Attachments
Patch (2.95 KB, patch)
2014-11-07 11:47 PST, Dániel Bátyai 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dániel Bátyai
Comment 1 2014-11-07 11:47:10 PST
Created attachment 241196 [details] Patch
Csaba Osztrogonác
Comment 2 2014-11-07 12:18:02 PST
Comment on attachment 241196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241196&action=review r=me , but CQ-, because it depends on bug138254 > Source/JavaScriptCore/jit/JITInlines.h:586 > - setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), regOp3Payload, regOp3Tag, TrustedImm32(op4)); > + setupArgumentsWithExecState(TrustedImm32(op1), TrustedImmPtr(identOp2), EABI_32BIT_DUMMY_ARG regOp3Payload, regOp3Tag, TrustedImm32(op4)); Good catch, ARM EABI doesn't like splitting the 64 bit sized JSValue to r3 and stack.
WebKit Commit Bot
Comment 3 2014-11-07 15:36:20 PST
Comment on attachment 241196 [details] Patch Clearing flags on attachment: 241196 Committed r175766: <http://trac.webkit.org/changeset/175766>
WebKit Commit Bot
Comment 4 2014-11-07 15:36:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.