Bug 137445

Summary: [GTK][Stable] webkitgtk-2.4.6: fails to build with --disable-video
Product: WebKit Reporter: Pacho Ramos <pachoramos1>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gnome
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Description Pacho Ramos 2014-10-06 02:11:17 PDT
And this error:
In file included from ./Source/WTF/wtf/Platform.h:636:0,
                 from ./Source/JavaScriptCore/config.h:30,
                 from Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:26:
./Source/WTF/wtf/FeatureDefines.h:880:2: error: #error "ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)"
 #error "ENABLE(VIDEO_TRACK) requires ENABLE(VIDEO)"
  ^

Looks similar to:
https://bugs.webkit.org/show_bug.cgi?id=121259

And could be caused by this change:
https://bugs.webkit.org/show_bug.cgi?id=134801

Full build.log is at:
https://bugs.gentoo.org/attachment.cgi?id=386082

From downstream report:
https://bugs.gentoo.org/show_bug.cgi?id=524518

Thanks
Comment 1 Pacho Ramos 2014-10-08 07:23:57 PDT
Patch attached to:
https://bugs.gentoo.org/show_bug.cgi?id=524518#c5

should fix this
Comment 2 Carlos Garcia Campos 2014-10-08 08:22:57 PDT
(In reply to comment #1)
> Patch attached to:
> https://bugs.gentoo.org/show_bug.cgi?id=524518#c5
> 
> should fix this

Could that patch be attached here as well?
Comment 3 Pacho Ramos 2014-10-08 13:46:19 PDT
Created attachment 239492 [details]
patch

Sure
Comment 4 Pacho Ramos 2014-10-08 13:47:20 PDT
Created attachment 239493 [details]
patch

(Credits for Michael Weber)
Comment 5 Carlos Garcia Campos 2014-10-22 02:39:20 PDT
Comment on attachment 239493 [details]
patch

Pushed to 2.4 branch, thanks!