Bug 133847

Summary:

[GTK] Implement HTML5 Gamepad API

Product:

WebKit

Reporter:

Michal Debski <m.debski>

Component:

WebKitGTK

Assignee:

ChangSeok Oh <changseok>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, bugs-noreply, cgarcia, changseok, darin, ews-watchlist, gyuyoung.kim, jinwoo7.song, mcatanzaro, ryuan.choi, sam, sergio, syoichi, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

98937, 133848, 133849, 133850, 133851, 133853, 133854, 212236, 212453, 213094, 217226, 217493, 217494, 217651

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Michal Debski 2014-06-13 06:06:39 PDT

This series of patches add support for HTML5 Gamepad API. This sould be conforming to spec:
http://www.w3.org/TR/gamepad/

It will consists of required changes in WebCore, layout tests for new implementation and events and Gamepad support in EFL and GTK port. There will be total of 5 patches - first 2 will introduce changes which can affect other features, next there will be common Gamepad implementation and in the end per port code.
More information about each change in relevant bug description.

Comment 1 Michal Debski 2014-06-23 03:25:34 PDT

Relevant bugs were updated with patches. Please take a look if you are interested.

Comment 2 ChangSeok Oh 2020-03-16 20:42:31 PDT

Gamepad API was implemented by mac port. This ticket may aim to implement the spec for non-mac ports. But patches look very old and outdated.
Michal, are you still working on this? If not, I'd like to take this over.

Comment 3 ChangSeok Oh 2020-03-27 04:39:22 PDT

My rough sketch is here, https://github.com/shivamidow/webkit/commits/gamepad-api.

Comment 4 Adrian Perez 2020-10-19 13:24:05 PDT

Created attachment 411785 [details]
Patch

Comment 5 Darin Adler 2020-10-19 13:54:54 PDT

Comment on attachment 411785 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411785&action=review

> ChangeLog:9
> +        because libmanette is not availble in the current Debian "old stable" (Buster), which

typo: available

Comment 6 Adrian Perez 2020-10-19 23:29:23 PDT

(In reply to Darin Adler from comment #5)
> Comment on attachment 411785 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411785&action=review
> 
> > ChangeLog:9
> > +        because libmanette is not availble in the current Debian "old stable" (Buster), which
> 
> typo: available

Thanks, I will fix this before landing.

Comment 7 Adrian Perez 2020-10-20 02:37:06 PDT

This changes the public build options, so I will need an approval
from a second reviewer, ideally working closely with the GTK port =)

Comment 8 Carlos Garcia Campos 2020-10-20 03:28:44 PDT

Comment on attachment 411785 [details]
Patch

LGTM

Comment 9 Adrian Perez 2020-10-20 03:55:17 PDT

(In reply to Carlos Garcia Campos from comment #8)
> Comment on attachment 411785 [details]
> Patch
> 
> LGTM

Thanks!

Comment 10 Adrian Perez 2020-10-20 04:26:18 PDT

Created attachment 411852 [details]
Patch for landing

Comment 11 EWS 2020-10-20 04:53:16 PDT

Committed r268725: <https://trac.webkit.org/changeset/268725>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411852 [details].