Bug 212236 – [GTK] Manette_INCLUDE_DIR and Manette_LIBRARY are undefined.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

The cmake complains Manette_INCLUDE_DIR and Manette_LIBRARY are missing where ENABLE_GAMEPAD is enabled.

[ChangSeok Oh]

Created attachment 399993 [details]
Patch

[ChangSeok Oh]

I think this is a necessary change. The imported_target argument does not set <XXX>_INCLUDE_DIR and <XXX>_LIBRARY according to the cmake doc. https://cmake.org/cmake/help/v3.13/module/FindPkgConfig.html#command:pkg_check_modules

[Don Olmstead]

Created attachment 400254 [details]
WIP Patch

In your original patch for manette I made a comment about copying what was happening in the Find modules within that directory already. This is what that would look like. I didn't see an actual release of manette on its GitLab so I'm not able to confirm the regex version finding but it should work. This will for sure set all the variables that the CMake references.

Also as an aside

    find_package(Manette 0.2.4 REQUIRED)
    if (NOT Manette_FOUND)
        message(FATAL_ERROR "libmanette is required for ENABLE_GAMEPAD")
    endif ()
    SET_AND_EXPOSE_TO_BUILD(USE_MANETTE TRUE)

You should also remove the REQUIRED as it will error before your FATAL_ERROR message is reached.

[ChangSeok Oh]

Created attachment 400312 [details]
Patch

[ChangSeok Oh]

(In reply to Don Olmstead from comment #3)
> In your original patch for manette I made a comment about copying what was
> happening in the Find modules within that directory already. This is what
> that would look like.

It's my bad. I did not catch this configuration failure due to the cache on my local. :P

> I didn't see an actual release of manette on its
> GitLab so I'm not able to confirm the regex version finding but it should
> work. This will for sure set all the variables that the CMake references.

I followed FindOpenJPEG.cmake as you said, and checked if the build is fine.

> 
> Also as an aside
> 
>     find_package(Manette 0.2.4 REQUIRED)
>     if (NOT Manette_FOUND)
>         message(FATAL_ERROR "libmanette is required for ENABLE_GAMEPAD")
>     endif ()
>     SET_AND_EXPOSE_TO_BUILD(USE_MANETTE TRUE)
> 
> You should also remove the REQUIRED as it will error before your FATAL_ERROR
> message is reached.

You're right. REQUIRED is removed.

[ChangSeok Oh]

Comment on attachment 400312 [details]
Patch

Thanks!

[EWS]

Committed r262201: <https://trac.webkit.org/changeset/262201>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400312 [details].