Summary: | [CSS Shapes] Simplify Polygon implementation | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hans Muller <giles_joplin> | ||||
Component: | CSS | Assignee: | Hans Muller <giles_joplin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, esprehn+autocc, glenn, kling, kondapallykalyan, zoltan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 130740 | ||||||
Bug Blocks: | 98664, 112917 | ||||||
Attachments: |
|
Description
Hans Muller
2014-03-31 11:39:48 PDT
Created attachment 228447 [details] Patch Only floats can specify shape-outside. For polygon shape values, the problem of finding the left and right exclusion edges reduces to finding the X axis limits of the polygon edges that overlap a particular line. This is a much simpler version of the problem that PolygonShape was designed for, and so the implementation can also be simplified. There's more about the new algorithm in http://hansmuller-webkit.blogspot.com/2014/03/a-simpler-algorithm-for-css-shapes.html. Comment on attachment 228447 [details]
Patch
r=me
Comment on attachment 228447 [details] Patch Clearing flags on attachment: 228447 Committed r166790: <http://trac.webkit.org/changeset/166790> All reviewed patches have been landed. Closing bug. |